Received-SPF: pass (google.com: domain of linux-kernel+bounces-144557-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 15 Apr 2024 09:02:38 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Sumadhura Kalyan <opensourcecond@gmail.com>
Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	gregkh@linuxfoundation.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: vc04_services: Re-align function parameters
Message-ID: <bea0a328-a27b-46b2-8893-1943d0404a29@moroto.mountain>
References: <20240414144614.125672-1-opensourcecond@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240414144614.125672-1-opensourcecond@gmail.com>

On Sun, Apr 14, 2024 at 08:16:14PM +0530, Sumadhura Kalyan wrote:
> From: sumadhura kalyan <opensourcecond@gmail.com>
        ^^^^^^^^^^^^^^^^
This will mess things up.

> 
> Checkpatch complains that:
> 
> CHECK: Lines should not end with a '('
> +typedef void (*vchiq_mmal_buffer_cb)(
> 
> Re-align the function parameters to make checkpatch happy.
> 
> Signed-off-by: Sumadhura Kalyan <opensourcecond@gmail.com>
> ---
> 
> v1 -> v2: Repharse the subject line.

Need more changelog here.

regards,
dan carpenter