Received-SPF: pass (google.com: domain of linux-kernel+bounces-144673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 15 Apr 2024 09:31:10 +0200
From: Francesco Dolcini <francesco@dolcini.it>
To: Udit Kumar <u-kumar1@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, kristo@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: Arranging mux and
 macro update
Message-ID: <20240415073110.GA7360@francesco-nb>
References: <20240415063329.3286600-1-u-kumar1@ti.com>
 <20240415063329.3286600-2-u-kumar1@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240415063329.3286600-2-u-kumar1@ti.com>

Hello,

On Mon, Apr 15, 2024 at 12:03:26PM +0530, Udit Kumar wrote:
> Updating J784S4 macro for pin mux instead of J721S2.
> 
> Also arranging pin mux in order of main_pmx0/1, wkup_pmx0/1/2/3
> along with fixing pin type for TX as output of wkup_uart.

Are you doing a refactoring + fixes in the same commit or I
misunderstood your commit message? 

If this is the case I would suggest to have separate commit for the fix
and the refactoring, with the fix being first in the series and with a
fixes tag.

From a quick look, this comment may apply to other commits in the
series.

Thanks,
Francesco