Received-SPF: pass (google.com: domain of linux-kernel+bounces-144688-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 15 Apr 2024 09:40:47 +0200
From: Maxime Ripard <mripard@kernel.org>
To: Jayesh Choudhary <j-choudhary@ti.com>
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, 
	Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, 
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: sii902x: Fix mode_valid hook
Message-ID: <20240415-venomous-enthusiastic-wildebeest-a7a446@houat>
References: <20240408081435.216927-1-j-choudhary@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha384;
	protocol="application/pgp-signature"; boundary="yll3teyvqekwzxye"
Content-Disposition: inline
In-Reply-To: <20240408081435.216927-1-j-choudhary@ti.com>


--yll3teyvqekwzxye
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Apr 08, 2024 at 01:44:35PM +0530, Jayesh Choudhary wrote:
> Currently, mode_valid hook returns all mode as valid. Add the check
> for the maximum and minimum pixel clock that the bridge can support
> while validating a mode.
>=20
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/si=
i902x.c
> index 8f84e98249c7..658819199c84 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -163,6 +163,16 @@
> =20
>  #define SII902X_AUDIO_PORT_INDEX		3
> =20
> +/*
> + * The maximum resolution supported by the HDMI bridge is 1080p@60Hz
> + * and 1920x1200 requiring a pixel clock of 165MHz and the minimum
> + * resolution supported is 480p@60Hz requiring a pixel clock of 25MHz
> + *
> + * (drm_display_mode clock is in kHz)
> + */
> +#define SII902X_MIN_PIXEL_CLOCK			25000
> +#define SII902X_MAX_PIXEL_CLOCK			165000
> +

You should probably add a KHZ suffix or something to make it obvious.
The natural unit for a frequency is Hertz.

>  struct sii902x {
>  	struct i2c_client *i2c;
>  	struct regmap *regmap;
> @@ -313,7 +323,11 @@ static int sii902x_get_modes(struct drm_connector *c=
onnector)
>  static enum drm_mode_status sii902x_mode_valid(struct drm_connector *con=
nector,
>  					       struct drm_display_mode *mode)
>  {
> -	/* TODO: check mode */
> +	if (mode->clock < SII902X_MIN_PIXEL_CLOCK)
> +		return MODE_CLOCK_LOW;
> +
> +	if (mode->clock > SII902X_MAX_PIXEL_CLOCK)
> +		return MODE_CLOCK_HIGH;
> =20
>  	return MODE_OK;
>  }

It's something you should do in atomic_check too

Maxime

--yll3teyvqekwzxye
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZhzZ/wAKCRAnX84Zoj2+
dvLmAX92oWeHZLr5hIKDGhemdrwUZRCEUzbQueD4PKBREYfIyJO/eJTudbScwDNA
vK/3U9EBgLvM/IuxlOU3CjE7cy0J+aLjzjXCPtdZi8mR1O3D/rXUwzHq8uCReJ94
lQRjoduC1w==
=+Fmk
-----END PGP SIGNATURE-----

--yll3teyvqekwzxye--