Received-SPF: pass (google.com: domain of linux-kernel+bounces-144694-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240414003434.2659-1-danny@orbstack.dev>
In-Reply-To: <20240414003434.2659-1-danny@orbstack.dev>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Mon, 15 Apr 2024 09:46:23 +0200
Message-ID: <CAJfpegvhym5UUBpsn2CMZ_duv3Ook6JDHF=h5A7Hz4dY1jU9PQ@mail.gmail.com>
Subject: Re: [PATCH] fuse: fix leaked ENOSYS error on first statx call
To: Danny Lin <danny@orbstack.dev>
Cc: stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Sun, 14 Apr 2024 at 02:34, Danny Lin <danny@orbstack.dev> wrote:
>
> FUSE attempts to detect server support for statx by trying it once and
> setting no_statx=1 if it fails with ENOSYS, but consider the following
> scenario:
>
> - Userspace (e.g. sh) calls stat() on a file
>   * succeeds
> - Userspace (e.g. lsd) calls statx(BTIME) on the same file
>   - request_mask = STATX_BASIC_STATS | STATX_BTIME
>   - first pass: sync=true due to differing cache_mask
>   - statx fails and returns ENOSYS
>   - set no_statx and retry
>   - retry sets mask = STATX_BASIC_STATS
>   - now mask == cache_mask; sync=false (time_before: still valid)
>   - so we take the "else if (stat)" path
>   - "err" is still ENOSYS from the failed statx call
>
> Fix this by zeroing "err" before retrying the failed call.

Thanks, applied.

Miklos