Received-SPF: pass (google.com: domain of linux-kernel+bounces-144754-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 15 Apr 2024 09:23:11 +0100
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: richard clark <richard.xnu.clark@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>, ulf.hansson@linaro.org,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sdhci: Fix SD card detection issue
Message-ID: <Zhzj7+nm8q03+p4g@shell.armlinux.org.uk>
References: <20240415070620.133143-1-richard.xnu.clark@gmail.com>
 <52c08a01-8357-44dd-b727-a06438ec6c30@intel.com>
 <ZhzVmmndefd5zDFh@shell.armlinux.org.uk>
 <CAJNi4rO16FDmRUCWyK=+DF5TbfryJLsX3VUN3j1mAeas7Rh84w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJNi4rO16FDmRUCWyK=+DF5TbfryJLsX3VUN3j1mAeas7Rh84w@mail.gmail.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Mon, Apr 15, 2024 at 04:17:14PM +0800, richard clark wrote:
> On Mon, Apr 15, 2024 at 3:22 PM Russell King (Oracle)
> <linux@armlinux.org.uk> wrote:
> >
> > On Mon, Apr 15, 2024 at 10:18:39AM +0300, Adrian Hunter wrote:
> > > On 15/04/24 10:06, Richard Clark wrote:
> > > > The mmc_gpio_get_cd(...) will return 0 called from sdhci_get_cd(...), which means
> > > > the card is not present. Actually, the card detection pin is active low by default
> > > > according to the SDHCI psec, thus the card detection result is not correct, more
> > >
> > > SDHCI spec covers the SDHCI lines.  GPIO is separate.
> >
> > ... and the key bit of information that should be mentioned is in the
> > case of a GPIO, the GPIO library can be told if a GPIO is active-high
> > or active-low in either firmware or via the GPIO lookup data, and this
> > should be used instead of drivers inventing their own "quirking".
> >
> Agree! But unfortunately, it seems I can't find the right place to
> handle this from either firmware or via the GPIO lookup data. Will be
> appreciated if any suggestion about that?!

If you're using DT, then, for example:

        cd-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;

is all it takes. If you are using firmware then GPIO lookup data isn't
what you should be using. I'm afraid I don't know the ACPI bindings for
SDHCI.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!