Received-SPF: pass (google.com: domain of linux-kernel+bounces-144756-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <369b29bf-66d8-4876-ae0c-a35f3c46973e@arm.com>
Date: Mon, 15 Apr 2024 13:55:25 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf test: Increase buffer size for Coresight basic tests
Content-Language: en-US
To: James Clark <james.clark@arm.com>, linux-perf-users@vger.kernel.org
Cc: Mike Leach <mike.leach@linaro.org>, Peter Zijlstra
 <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
 Arnaldo Carvalho de Melo <acme@kernel.org>,
 Namhyung Kim <namhyung@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
 Adrian Hunter <adrian.hunter@intel.com>, coresight@lists.linaro.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240326113749.257250-1-james.clark@arm.com>
 <5a4023aa-af9b-48d2-84f3-a0b9b30dc54e@arm.com>
 <7f5c32dd-edc6-4b53-9cdd-780756f5536c@arm.com>
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <7f5c32dd-edc6-4b53-9cdd-780756f5536c@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/12/24 13:52, James Clark wrote:
> 
> 
> On 12/04/2024 08:04, Anshuman Khandual wrote:
>>
>>
>> On 3/26/24 17:07, James Clark wrote:
>>> These tests record in a mode that includes kernel trace but look for
>>> samples of a userspace process. This makes them sensitive to any kernel
>>> compilation options that increase the amount of time spent in the
>>> kernel. If the trace buffer is completely filled before userspace is
>>> reached then the test will fail. Double the buffer size to fix this.
>>
>> This is a valid concern to address, but just wondering how did we arrive
>> at the conclusion that doubling the buffer size i.e making that 8M will
>> solve the problem positively for vast number of kerne build scenarios ?
>>
> 
> Nobody else has reported anything yet, if it happens again we can always
> increase it again if that is what the issue is. I had most of the kernel
> debugging stuff turned on like memory debugging etc, which is probably
> why I ran into it and 8MB fixed it for me. So I'm not sure if there is
> much more that could be added.

Makes sense,

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> 
>>>
>>> The other tests in the same file aren't sensitive to this for various
>>> reasons, for example the iterate devices test filters by userspace
>>> trace only. But in order to keep coverage of all the modes, increase the
>>> buffer size rather than filtering by userspace for the basic tests.
>>>
>>> Fixes: d1efa4a0a696 ("perf cs-etm: Add separate decode paths for timeless and per-thread modes")
>>> Signed-off-by: James Clark <james.clark@arm.com>
>>> ---
>>>  tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh
>>> index 65dd85207125..3302ea0b9672 100755
>>> --- a/tools/perf/tests/shell/test_arm_coresight.sh
>>> +++ b/tools/perf/tests/shell/test_arm_coresight.sh
>>> @@ -188,7 +188,7 @@ arm_cs_etm_snapshot_test() {
>>>  
>>>  arm_cs_etm_basic_test() {
>>>  	echo "Recording trace with '$*'"
>>> -	perf record -o ${perfdata} "$@" -- ls > /dev/null 2>&1
>>> +	perf record -o ${perfdata} "$@" -m,8M -- ls > /dev/null 2>&1
>>>  
>>>  	perf_script_branch_samples ls &&
>>>  	perf_report_branch_samples ls &&
> _______________________________________________
> CoreSight mailing list -- coresight@lists.linaro.org
> To unsubscribe send an email to coresight-leave@lists.linaro.org