Message-ID: <47986AC0.8000806@niasdigital.com>
Date: Thu, 24 Jan 2008 21:38:56 +1100
From: Ben Nizette <bn@niasdigital.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20070801)
MIME-Version: 1.0
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32
References: <47972AD2.20801@niasdigital.com> <20080124112911.0b1592f4@dhcp-252-066.norway.atmel.com>
In-Reply-To: <20080124112911.0b1592f4@dhcp-252-066.norway.atmel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 912
Lines: 32

Haavard Skinnemoen wrote:
> On Wed, 23 Jan 2008 22:53:54 +1100
> Ben Nizette <bn@niasdigital.com> wrote:
> 
>>  /*
>> + * We just keep an empty definition of this around (a-la the asm-generic
>> + * implementation) to keep /dev/mem happy
>> + */
>> +#define unxlate_dev_mem_ptr(p, a) {}
> 
> Thanks, but this should be either
> 
> #define unxlate_dev_mem_ptr(p, a) do { } while (0)
> 
> or
> 
> static inline void unxlate_dev_mem_ptr(unsigned long phys, void *addr)
> {
> }
> 
> I prefer the latter.

Yeah I don't know what came over me; Mia culpa :-)

I prefer the latter too, though I think I was striving for consistency with the xlate_dev_mem_ptr #define.

--Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/