Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1299762lqp; Mon, 15 Apr 2024 02:02:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVv7pKgBAHiw5zAJAEKmTVt8asd99fglfNk2lPqyG4tKkFrk4BsHwyEzQx92uzbFeZRL8I9u1iZRqZtOmga4MFgVjjHoiFl0TbsqgM4dw== X-Google-Smtp-Source: AGHT+IHwgfYZctSNnRB4lwo+L/Rd/sFKdqIgqvGJoIqAkD9o7MlrDSZg+tyEHXhtDB8TshSGeiN5 X-Received: by 2002:a05:6602:379a:b0:7d5:f78f:ab21 with SMTP id be26-20020a056602379a00b007d5f78fab21mr13407545iob.11.1713171744553; Mon, 15 Apr 2024 02:02:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713171744; cv=pass; d=google.com; s=arc-20160816; b=SGR/XEP+4qAbeIiUCyve8EqIgWYfYjp0EMo5u67WssvXkABPz/n5TF5sVPNRL6zYUm ATrsIicZxXpA7Sg1AHyQdeEcj/2gpsOF3Zc7lei+ojXub5eqHbQ6ZqcD2Yr2eyA6E63c QaG23yVOGKRovrriH/LBQ4w2/2jhBzHAMJsB9J9rbdJw6fmyPwwouqNEtlxgmbTuZ0EK 4kKjsOAYEtFnZp9W/KpH5a1dwzjt0e/zR/f5etX+dW7NiqzYPgcmTGVGBdkkJvM02WTm jF1eILrRcSW1KxsF1ahjFnIyOJLfVF/c722346GUvglGufE0VxWQ5Q1Ip0YT2Jq0KMVm sAsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=LOuG8NJL2VgUgOVwsN9HbuRgdctQBBewzPSMUZJ1O1Y=; fh=gJz0lL5C+LY/zULWTYw+Nu+u6bfUjIZZonNaJNi7MNU=; b=agpf5KMmFyz6OZNShB7CbBg+Oy3+NM0Dk79PsZCZScgmnZPt4o3al6P01tWIVpxOr/ Z4lV+FaP8HlJcsn+tpKdm2FpbXbhEor8OB8bCAnXNRBRlGfqcCUTPkpFAINeAkB5bJn+ L+eSF5NlvWYdxmY1ccYmd+PDxSX/I+lLecz3HITTS79ZaCE+zLA5bOcCj1wBRlakj5z6 /d9QjyMcEshgKJ5lOVshgFkmSrrAZXUy/bfDhlZnXQJ8QP7aeX1qnrbkH1kVZCdlfEAB f/u4RE1aUKKKg9oorOtltx4L9966VOzvv3fyWco2ElMBKV7Afz5RULVXeu/5XpST9CcE wqSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-144791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144791-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a21-20020a634d15000000b005dbcf612461si7638583pgb.416.2024.04.15.02.02.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 02:02:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-144791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144791-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 79E8BB269AC for ; Mon, 15 Apr 2024 08:47:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C67339FF4; Mon, 15 Apr 2024 08:47:12 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E7B53FE2A; Mon, 15 Apr 2024 08:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713170832; cv=none; b=k3Sjab84lC7nc97l3EAr4L6Awjee8EGEqjzSAU92VjTGNcdj5u6tPsn0s4QlH/mZU+vshH/tkY6z/Y8fzl8vz4VryHFGxTglAWVEBsL4+lyYK5VE5hOznP7cdiHUgYXjVUaq6o6z0g2hqskVwRtD7fX6SCwNzol+uMqV0VbSKrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713170832; c=relaxed/simple; bh=K1Izgm9M9NYPkvpelnhwjfrFMBk3G5O77eZS6YtM65M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VaFBB4vO2E+GeJ5aKfXUqBsy8XSFBDkRF/F8J3I1h65AlgUFNlCQuV/p0BvCeSBFsxOx/EQXO7FQ2XDD0emphAbsPAqBWWAZWAEt1ZfW6rp3h0izCXDHmgc6od156yGcXknXOclUf5MdBglLvFLWfO2dr4HxBWq3CBzdA1ECrmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 528D7DA7; Mon, 15 Apr 2024 01:47:38 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CDE163F64C; Mon, 15 Apr 2024 01:47:07 -0700 (PDT) Date: Mon, 15 Apr 2024 09:47:05 +0100 From: Sudeep Holla To: Yunhui Cui Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, bhelgaas@google.com, james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com, john.garry@huawei.com, Jonathan.Cameron@huawei.com, pierre.gondois@arm.com, tiantao6@huawei.com Subject: Re: [PATCH v2 1/3] riscv: cacheinfo: remove the useless parameter (node) of ci_leaf_init() Message-ID: References: <20240414025826.64025-1-cuiyunhui@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240414025826.64025-1-cuiyunhui@bytedance.com> On Sun, Apr 14, 2024 at 10:58:24AM +0800, Yunhui Cui wrote: > The implementation of the ci_leaf_init() function body and the caller > do not use the input parameter (struct device_node *node), so remove it. > > Fixes: 6a24915145c9 ("Revert "riscv: Set more data to cacheinfo"") Not sure if this can be tagged as fix, but I leave that to RISC-V maintainers. With the comment in PATCH 2/3 fixed based on your experiment, feel free to add to the whole series, Reviewed-by: Sudeep Holla -- Regards, Sudeep