Received-SPF: pass (google.com: domain of linux-kernel+bounces-144817-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <48414875-187d-4afe-ae87-6431b845eaca@gmx.net>
Date: Mon, 15 Apr 2024 11:06:32 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/6] arm64: dts: broadcom: Add support for BCM2712
To: Phil Elwell <phil@raspberrypi.com>
Cc: Andrea della Porta <andrea.porta@suse.com>, Rob Herring
 <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Florian Fainelli <florian.fainelli@broadcom.com>,
 Linus Walleij <linus.walleij@linaro.org>,
 Jonathan Bell <jonathan@raspberrypi.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, Adrian Hunter
 <adrian.hunter@intel.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, linux-kernel@vger.kernel.org,
 Al Cooper <alcooperx@gmail.com>, linux-mmc@vger.kernel.org,
 Kamal Dasu <kamal.dasu@broadcom.com>, linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
References: <cover.1713036964.git.andrea.porta@suse.com>
 <0ab5a768d686cb634f7144da266c9246e9e90cb4.1713036964.git.andrea.porta@suse.com>
 <d7b884dd-9b70-41c3-ac2a-66b54c26d08a@gmx.net>
 <CAMEGJJ2R-WEqs+LgqMwDQJ_QHF840RYAqVGkbWxBs70anv6M4w@mail.gmail.com>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <CAMEGJJ2R-WEqs+LgqMwDQJ_QHF840RYAqVGkbWxBs70anv6M4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:7tHIbPC4OPE=;0o3Qmm8vlD26+gY5h7dXTZ9iQi1
 zj0OK3X3lReB4XHePGLPIK9wdIbP7X4j2VoFizl/ccS+yL4hb9oRt9smL5ZlUY+vqOdGmSP7j
 0sbG9K7r9KzSS5NCQ/SEWBQ+l1vqGudz9ZawGrmzICjlB4+JYpKM9w0CVcFt/Aah5zDLCEaH2
 HaxlTbcBcuWPRVGlnaYcpNnpp3drvpRQSLlTvqmKwuHt5YsTRHjC1Sen5e8L2QMYuh1R+MEKL
 sJGLlGYS/lsj9yVocB7RMdEPNIAF13HmGJ7E5dTGRrOTelYmJ21NCTcCfXa8Ak4Gaf0YAMXZ7
 VEVYSL3y5qEYVk4cqHEK+YxnX3cRZu6t9EpfYtAWw4S9YqbaXy+oK3PCOUkgaTjQuwtWlD+IY
 HlEohfSXso/PQnkVuRG4XtwTN9Hsch4sbHShTA0/F4MgvCPy9ixW2uw5CsI5Mu7J2X79jnH7M
 AhUOv7EObhjKKBPnpzAYpyKEg51ZLBAr1cNXtlRkfHnPGZQrPqT132BeJokMQF3lNtJvi6QAE
 pqtbzcRHtE3z+WD/r/roW1/wvtTfsOZIoGtK59qh7MQiWHkwQtRboe2YrYSzB+qUYPc/z6CuN
 oZkmKF1YJjajqlMAIE1VgXrhFGbli3mTSnvDZsWAVLs539XVaHIYHFzEkuSZcdhDMiWi0ByEV
 V6qGE+xXW+it6EgjNWQSlgxcGdToO5pNiRJakn+VXKX2CkYwOAtrBd9b9GsJqvJ+U9F0k7G5L
 doZ5ES2CVfyd1VFjJBDYw06ULf8H+D/JRg0yJrnjuXBC2h8EZ4Xfz+UEqOsAEuKBEQFxoqEmu
 u2+T1wt9huhjy3uB2dBeCErCyJnUiu2CJZ6L9GV/UI/4s=

Hi Phil,

Am 15.04.24 um 10:52 schrieb Phil Elwell:
> Stefan,
>
>
> On Mon, 15 Apr 2024 at 09:20, Stefan Wahren <wahrenst@gmx.net> wrote:
>> Hi Phil,
>>
>> Am 14.04.24 um 00:14 schrieb Andrea della Porta:
>>> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
>>> ---
>>>    arch/arm64/boot/dts/broadcom/Makefile         |   1 +
>>>    .../boot/dts/broadcom/bcm2712-rpi-5-b.dts     | 313 +++++++
>>>    arch/arm64/boot/dts/broadcom/bcm2712-rpi.dtsi |  81 ++
>>>    arch/arm64/boot/dts/broadcom/bcm2712.dtsi     | 841 +++++++++++++++=
+++
>>>    4 files changed, 1236 insertions(+)
>>>    create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
>>>    create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi.dtsi
>>>    create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/d=
ts/broadcom/Makefile
>>> index 8b4591ddd27c..92565e9781ad 100644
>>> --- a/arch/arm64/boot/dts/broadcom/Makefile
>>> +++ b/arch/arm64/boot/dts/broadcom/Makefile
>>> @@ -6,6 +6,7 @@ DTC_FLAGS :=3D -@
>>>    dtb-$(CONFIG_ARCH_BCM2835) +=3D bcm2711-rpi-400.dtb \
>>>                              bcm2711-rpi-4-b.dtb \
>>>                              bcm2711-rpi-cm4-io.dtb \
>>> +                           bcm2712-rpi-5-b.dtb \
>>>                              bcm2837-rpi-3-a-plus.dtb \
>>>                              bcm2837-rpi-3-b.dtb \
>>>                              bcm2837-rpi-3-b-plus.dtb \
>>> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/a=
rm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
>>> new file mode 100644
>>> index 000000000000..2ce180a54e5b
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
>>> @@ -0,0 +1,313 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/dts-v1/;
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/interrupt-controller/irq.h>
>>> +#include <dt-bindings/pwm/pwm.h>
>>> +#include <dt-bindings/reset/raspberrypi,firmware-reset.h>
>>> +
>>> +#define spi0 _spi0
>>> +#define uart0 _uart0
>>> +
>>> +#include "bcm2712.dtsi"
>>> +
>>> +#undef spi0
>>> +#undef uart0
>>> +
>>> +/ {
>>> +     compatible =3D "raspberrypi,5-model-b", "brcm,bcm2712";
>>> +     model =3D "Raspberry Pi 5";
>>> +
>>>
>> according to this downstream commit [1] it's just called "Raspberry Pi
>> 5" without Model B, but the filename and the compatible says something
>> different. Is there still a chance to get this consistent or is it too
>> late because the firmware expect the compatible?
>>
>> [1] -
>> https://github.com/raspberrypi/linux/commit/99e359d2f2da2c820fd2a30b1ad=
08b32c9549adb
> Nothing cares about the compatible string, but the product name was
> changed too late for the firmware, which expects the current DTB file
> name.
should i send a pull request to address the compatible? This would avoid
a little bit confusion in the upstreaming process, because
devicetree/bindings/arm/bcm/bcm2835.yaml needs to be updated as well.

Best regards
>   I'm happy with the naming as it stands, since we use Pi 4 to
> refer to all the BCM2711-based devices, and Pi 5 can include CM5.
>
> Phil