Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1318299lqp; Mon, 15 Apr 2024 02:45:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQr2i5U/Znm4ERcuzEQl5aU/wVfdsNMizLsvmcjPXSsgt9hHye32yf2aNu6LrUwoNl270jJQXv5a0Z0lqJ3jJxKCNMzqj2uB7trW6zyw== X-Google-Smtp-Source: AGHT+IHiTroIPNwUmRVZ+Uy+vsUiKupAgMxUJrtR+NZ0k3FgHnQYQmAycoyS7A+5SYKsWA7CnT2M X-Received: by 2002:a9d:61d7:0:b0:6eb:7d1d:d458 with SMTP id h23-20020a9d61d7000000b006eb7d1dd458mr3120356otk.17.1713174326388; Mon, 15 Apr 2024 02:45:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713174326; cv=pass; d=google.com; s=arc-20160816; b=IFEeHmQNIAb6icWNCTON9Ju2NiM/TXPfqZP2bt8UPpyfadUKWg/9tchIkjRUeNF1Qg iX62tmC1tHYYDDLVC7SszpYWpR59YPeN+lCToQlWi9FpP/O+QXrd6mq6YdDoVjPm6YQE O72iuBHW4JGFnQ78SHverrFdx9Xeop2OIn9AvBrV7e0e3RIkzEYvlYp8MgP5f5ZqSjIh K2rhR+FGGQfoL20f87psQpF4jQDMbwVWYrmg0BzS9qBU6a+MKlKY0ep7O8mVHFAFFYy0 hVAAbV8Gp1ySEBQgKcBOF3SmkouSb69lCaSpADihXqhX01ELx8JDYXyFm7FAOPGyo3Rd Miog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=3dwAMvNpKeQ9PatZlAuEMPbAqrw8p29gML5z9fKjLW4=; fh=T8mowtOCG23ZOCvuFNP7usiIGrpFYhfD31sgURab6Nw=; b=rBN68cFJydufMf9oEkNZvDTL8ndY+By/EBSklITXWcTtAtI5RSB4Xy48iKDm37ryMZ jhrW7tyN/HqHVL7OCiuv7tclHSvFXYWMwpVOVmV7oDGdK/0jw6umJ7tPlBCUV32CJ5/O pw1auKFZUS6KZWncJMV9+K23N5sL7he9aObVfPm9RKT8WJyhZklvHPwtSGhHk4Kpl5dO dkP+kN3D6zhZ8+EC6ZpiF0xumNquLGq7OXVYKVWuYPA3oSZfDkHnpiBrHc6LLKMYC/rN fXJeANKZeeDGTmdbI/aalpt2f/Qk/dTGZkIZQF2M95Og4cJ4zNPj74Wd2hzv6YU8UhL0 Yg3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=I2DeG4QO; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-144852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 20-20020a05620a04d400b0078ede04e1d9si3706921qks.270.2024.04.15.02.45.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 02:45:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=I2DeG4QO; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-144852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 20B5D1C20E0A for ; Mon, 15 Apr 2024 09:45:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E63C34EB20; Mon, 15 Apr 2024 09:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="I2DeG4QO" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E49174D9FF for ; Mon, 15 Apr 2024 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713174300; cv=none; b=L7N6wlwsDo6OQ3S4BGFxbbArp/vHUxRMj/1MV5y6pT51tQCg17FrovRzPX4gQryHFl83ZJEa41FizxyE57PWEx+8JDWaimuiwaSnkRtXn9VIBYj4oyjCwB8+fYLo1XawP78QcIhBmKREVVmWkkS7CzwN4jeSM9p96XixTKnVopA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713174300; c=relaxed/simple; bh=VtwuyubYUYZ4mi1Ujdo1t+RKF4tKBpowGisw1EN28aI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qNM/Y1TlXLQfXiym/2Eg4j3XKel5TJJykSFiOch16Io8/b2qsyUGJ1LtOi0CQXhrp5ZTEdqngoJBB1PYglsvFRFqDO82YxG76GmBPoFWmdcy/11xKY7yrhGLT7VBTVZrxUxRRZTQDKjiwjw7k9A0krewuqhcPSHF31+AmjhdMlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=I2DeG4QO; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dwAMvNpKeQ9PatZlAuEMPbAqrw8p29gML5z9fKjLW4=; b=I2DeG4QOJP6IjEQADh7wSKhTjo Y5YVYaMxGCKJTzJMVB2H96z44xgVc+bol/xfbV/wl22KcAYKtX41YnFvNRSFeOVwtu3XBfsbSDEA7 lUQQhFZ20aiqxcFYYv5EBOeeKucw41NswFlZyrRVCDFZXqczEpxyPwKkVLes/iVoDFmKlaTM+WgDn CU3beLRvx2cDdHtoixy9tzmAi0ptBAg6EFfji/pabx9EqiLdQuzZA8rlK0fHcuVF8mgvP9qeyQDVQ 7mahxUdsejWTTat/6Aq/aErtF8I1JUJhXt1P6kcn3fZerv8+cVnslF1wlAXIi6iq2RNSVHScdRSPN O2Cvg27w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42636) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rwItN-0005vm-11; Mon, 15 Apr 2024 10:44:49 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rwItM-00026W-TT; Mon, 15 Apr 2024 10:44:48 +0100 Date: Mon, 15 Apr 2024 10:44:48 +0100 From: "Russell King (Oracle)" To: Tetsuo Handa Cc: Mark Rutland , Kees Cook , Linux ARM , syzbot , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hardening?] [mm?] BUG: bad usercopy in fpa_set Message-ID: References: <0000000000004cf5c205faf1c7f3@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Mon, Apr 15, 2024 at 06:38:33PM +0900, Tetsuo Handa wrote: > On 2024/04/15 18:02, Mark Rutland wrote: > > 08626a6056aad824 ("arm: Implement thread_struct whitelist for hardened usercopy") > > > > That commit says that all accesses are bounce-buffered and bypass the check, > > but AFAICT the fpa_set() code hasn't changed since then, so either that was > > wrong or the user_regset_copyin() code has changed. > > Then, can we go with https://lkml.kernel.org/r/0b49d91b-511f-449e-b7c3-93b2ccce6c49@I-love.SAKURA.ne.jp ? Have you visited that URL? It doesn't point to an email containing a patch, so sorry, I don't know what patch you're referring to. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!