Received-SPF: pass (google.com: domain of linux-kernel+bounces-144914-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240415101345.3807776-1-vchernou@cisco.com>
In-Reply-To: <20240415101345.3807776-1-vchernou@cisco.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Mon, 15 Apr 2024 19:32:27 +0900
Message-ID: <CAK7LNAQ3VJN5Ga1aJnrpaPoPaKMCZR3dauo-SWaH9=y9zv1F5w@mail.gmail.com>
Subject: Re: [PATCH] scripts/Makefile.build: fix ext mod subdirs build with
 separate src,build dirs
To: Valerii Chernous <vchernou@cisco.com>
Cc: Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, xe-linux-external@cisco.com, 
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 15, 2024 at 7:14=E2=80=AFPM Valerii Chernous <vchernou@cisco.co=
m> wrote:
>
> The change allow to build external modules with nested makefiles.
> Current unofficial way(using "src" variable) allow to build
> external(out of tree) kernel module with separating source and build
> artifacts dirs but with nested makefiles it doesn't work properly.
> Build system trap to recursion inside makefiles, articafts output dir
> path grow with each iteration until exceed max path len and build failed
> This fix update "src" var during processing subdirs and resolve
> recursion issue
> Usage example:
> make -C KERNEL_SOURCE_TREE M=3DBUILD_OUT_DIR src=3DEXT_MOD_SRC_DIR module=
s
>
> Cc: Valerii Chernous <vchernou@cisco.com>
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Valerii Chernous <vchernou@cisco.com>


NACK.

Please do not send hacks over again.


> ---
>  scripts/Makefile.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index a293950e2e07..75ea9052ea4a 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -490,6 +490,7 @@ $(single-subdir-goals): $(single-subdirs)
>  PHONY +=3D $(subdir-ym)
>  $(subdir-ym):
>         $(Q)$(MAKE) $(build)=3D$@ \
> +       $(if $(findstring command line,$(origin src)),src=3D$(patsubst $(=
obj)/%,$(src)/%,$@)) \
>         need-builtin=3D$(if $(filter $@/built-in.a, $(subdir-builtin)),1)=
 \
>         need-modorder=3D$(if $(filter $@/modules.order, $(subdir-modorder=
)),1) \
>         $(filter $@/%, $(single-subdir-goals))
> --
> 2.35.6
>


--=20
Best Regards
Masahiro Yamada