Received-SPF: pass (google.com: domain of linux-kernel+bounces-144915-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f3deadf1-8bb1-422d-a7b6-d0e0de98484f@collabora.com>
Date: Mon, 15 Apr 2024 12:33:28 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183-kukui: Drop bogus
 output-enable property
To: Chen-Yu Tsai <wenst@chromium.org>,
 Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org
References: <20240412075613.1200048-1-wenst@chromium.org>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <20240412075613.1200048-1-wenst@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 12/04/24 09:56, Chen-Yu Tsai ha scritto:
> The "output-enable" property is set on uart1's RTS pin. This is bogus
> because the hardware does not actually have a controllable output
> buffer. Secondly, the implementation incorrectly treats this property
> as a request to switch the pin to GPIO output. This does not fit the
> intended semantic of "output-enable" and it does not have any affect
> either because the pin is muxed to the UART function, not the GPIO
> function.
> 
> Drop the property.
> 
> Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>