Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1338559lqp; Mon, 15 Apr 2024 03:35:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWvFTzYZ4Pd2cMu94bRLxCMEoie9ybAMNEnFz4F0KnJhZXs1DYgJf3/TuyQCDoc3+IL5CLU015q6aGYB1KxPRvBhJnhxg6p54JfoAl/Kw== X-Google-Smtp-Source: AGHT+IHHTaNEUjp+vBmBSnPTUFmtRbRx2K1wvgqXah2ot/Hun06Vwp/GqixwQfmszbyIhTid2GNh X-Received: by 2002:a17:907:940e:b0:a52:231a:52b1 with SMTP id dk14-20020a170907940e00b00a52231a52b1mr6963662ejc.47.1713177343750; Mon, 15 Apr 2024 03:35:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713177343; cv=pass; d=google.com; s=arc-20160816; b=VjyhK9C+x/L0nBNlipSc1vN4E7ujbbBMlbFoizsiOAMVkeBBhVpf8JvCvngH2W1TvI isWU7qJDYlRM0RvvDG3+C+0Xy7NMAZoYoNvz5d42e/68boNs5zbvc8vnYM6xp6bucNhq /EbFtGwPC6vd8+JORqrhh/bnc488+OwUtr9ehxHQLzBM0LZaqUZOAQTbwGUfLB3a+xMy 6uP2U/4sBGxUFlePZJL3NRTxBvrh/HErBvX/vZK3uiw353uUK+EFeh4bn8YzjJKvYGAK qvqtEdkBh/MlYct144JzdujJe2ixuzwDl15al/Q/rcomUfRUksE72xNqTD2prR87sCnV A+dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=zb0AcHYJj4Z6uH7ult623PxyC0JUgNiN0woF1QKFzpM=; fh=957SDEUH58vyjWu3M0bNnX92h3UU8OSGLnSzkgsqV3E=; b=kzllXOHsyVI3hWxvw8VgpGeYRHWtY487GriQ9SjB4HWSLjBmfiqDA00Jq8/tlCoqDA MUrLDIf3vDZTY5gqaLNrfSSvAGs1/avCjt0hJ/aooTRaZhUgrEozbIdsGQ5KJOSr3V7D sOeSMmm14Wscvnr/dq8R5upKsAClOY8Z2iz3xRHxHqWjRoPk0DzJjAfbBxwJcWeBy1AU 4z9MxfRj3gz27IPhFOtdvfkYEAEaiQ5UeMIJ7caR9lxpDYbV/WiK6ydkAXYsN0UAiTZX 0W8FMoMRCrsdSmkM8bIBwbx/LZadkmO3Yomd9IHJiD/5tdvukNGJt5QpvYWG9usTIdKk NHog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=i-love.sakura.ne.jp); spf=pass (google.com: domain of linux-kernel+bounces-144919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144919-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i24-20020a170906265800b00a52331ab12dsi3400176ejc.267.2024.04.15.03.35.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 03:35:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=i-love.sakura.ne.jp); spf=pass (google.com: domain of linux-kernel+bounces-144919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144919-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7A14C1F22A09 for ; Mon, 15 Apr 2024 10:35:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB7E65B698; Mon, 15 Apr 2024 10:35:35 +0000 (UTC) Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEBCA59155 for ; Mon, 15 Apr 2024 10:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.181.97.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713177335; cv=none; b=DRnk0BFL65I+8h/VNIYJAhpxEkHc3oRmTLcvu+RpUGn2yhBJ9DUT4F6O1SNxxYMknC6+QTSLyfuOLV01lSl0zjOiixpJ90/f1PwJkLDzTqqY507sNwbBVp3zh3r0zgJjWCakfgl6RcDv4MBXVM3vhbmLttS71sid/3/PaR0RHsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713177335; c=relaxed/simple; bh=i7kl6gVzz/rcqz5Ofjqm0TusNLII/PSkB02AHrTvw4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bmd+ySWkeierNvUnxey6vBr1d4gUn6/E7aF+nE6KwzH++D2am4hxAI8tvF3aghXGh1UmgmEGKUootmtXJpwugqz6w8a3LBMPzUeFBYfC6gmCEaGVq1BfpGUUTzDXxicUsbemHK8j5BpGaLH2p4Dla3TibehO8u4o2scl4IK/9YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp; arc=none smtp.client-ip=202.181.97.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp Received: from fsav120.sakura.ne.jp (fsav120.sakura.ne.jp [27.133.134.247]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 43F9cXf4009055; Mon, 15 Apr 2024 18:38:33 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav120.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav120.sakura.ne.jp); Mon, 15 Apr 2024 18:38:33 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav120.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 43F9cXM1009052 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Mon, 15 Apr 2024 18:38:33 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Mon, 15 Apr 2024 18:38:33 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [hardening?] [mm?] BUG: bad usercopy in fpa_set To: Mark Rutland , "Russell King (Oracle)" , Kees Cook Cc: Linux ARM , syzbot , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <0000000000004cf5c205faf1c7f3@google.com> Content-Language: en-US From: Tetsuo Handa In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024/04/15 18:02, Mark Rutland wrote: > 08626a6056aad824 ("arm: Implement thread_struct whitelist for hardened usercopy") > > That commit says that all accesses are bounce-buffered and bypass the check, > but AFAICT the fpa_set() code hasn't changed since then, so either that was > wrong or the user_regset_copyin() code has changed. Then, can we go with https://lkml.kernel.org/r/0b49d91b-511f-449e-b7c3-93b2ccce6c49@I-love.SAKURA.ne.jp ?