Received-SPF: pass (google.com: domain of linux-kernel+bounces-144981-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <86039c78-d05f-4bae-b2cb-55bbfca8f798@nvidia.com>
Date: Mon, 15 Apr 2024 16:52:08 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2] PCI: tegra194: Fix probe path for Endpoint mode
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
 bhelgaas@google.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
 linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
 linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com,
 sagar.tv@gmail.com
References: <20240412191402.GA10938@bhelgaas>
Content-Language: en-US
From: Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20240412191402.GA10938@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3ZmMlJnMjM4Z0VsTE5mR1NMNEg1TkhUcXcrQkZCbkRZVXdDb0pFQlkyLzNu?=
 =?utf-8?B?dFVlanJ1ekFUSFplMEVkRUkwVEdFeGVUVEt6Tlh3dnRRaGRtTE9iZTk4WElx?=
 =?utf-8?B?ZXJhdG1waU5qVGhieVoySTQ3SmtKaUF1N1luZ1dkeFFmT2ZMVnppUXVITFkz?=
 =?utf-8?B?YWZVdEw5RitBbngvNndCNXo5MzN4d3FXVjNXMjk4U1BYNUZQR1ErbVRhc3g0?=
 =?utf-8?B?YXQ3cmIxZ29xbEt4RFBXdnErMzliRFF3OFNUMFF4SEtjOUQ0Y2xzSFFTTHpO?=
 =?utf-8?B?aC8vTjJlTlR3SWcyZzlyZm5qeE13SDJkanFaeXVVRDVTN0haVzZWM25WK3JH?=
 =?utf-8?B?YmFWNTcwbkdNUlpBdUF5c1d4RDVraVpkY2dheEhFajFGVEgvaVZNa3hQMEND?=
 =?utf-8?B?UjhrS0ZkWGtnM0FYczFXODlmdlJ4TGg2dDc2NUFLQmw4bDlnRWdESmFleE1F?=
 =?utf-8?B?cGxOTjQyRnVneXdDeGI5ZnA0cm9CT3U1aU1LTEYxWTNZQkkwRmM0OEM3bURI?=
 =?utf-8?B?RjRJMkREdXppaUdjVmFpaU9BVW1CS2NQMExqd1dmMFhDOWpkOVY5MUhvWlRD?=
 =?utf-8?B?V1ltWjg5NWE4Z3FyWSthSGczSXViZUtwVUE4Y3JxaGhhMk9idmVXNzlaa0E4?=
 =?utf-8?B?dTExSnErNTNsVUlnOFJlTis2eTNVNHhZM0RBWlZnV0ovaEhDck9jV3dqWWZr?=
 =?utf-8?B?RHpGQTEvMWtrNVVVa1NEOHMzYUxEUm0vZWtUZ0IvVmFjSmd4cHV4VjhqdWFV?=
 =?utf-8?B?ZUZQRFdXZEdsRzRST25GTnczaC9qYzZzbWlWbHQ4eUI4VUd4dDMwSWljVTJ1?=
 =?utf-8?B?V1IzMXk1eWxZUXZlZkl1WDJSemk3VzZrc0JZUFpWNkZoZHYxUDE4RVpqUUpG?=
 =?utf-8?B?bDJkUEt4NEZ6aHRscTNXSks3MllwTWlNQlR4REJiTXpvUC8xcCtsQzN5OWZW?=
 =?utf-8?B?OVRtbE0yenhOajF6V0dtSWhDSjNxdDhkbFNIRm9LWU5DcEN2VjhnOS9QRlM1?=
 =?utf-8?B?K3gzMmNQUFFxdGRGTEs3REhBWFBXMFpKZ2FlVHVhd1V0eEhoRDdvVEhYMnlS?=
 =?utf-8?B?ckdGZVd1NEM0L0dLcHRaTk1zSXJMR2pCWVN2TEdkUGZRS09GNzF3K0I3UUI2?=
 =?utf-8?B?RUtuSmFYVEtMT0JJYk1WN3ZidzJSbjhDQWNjSjE1ZlRFVGJkRmxwS0RFMGc0?=
 =?utf-8?B?aXpHR3RtTjUvRmNTTVdrSVlvSVgyRW4wdnpMalZpNHlhc3RxaUs5NXpGQ0NV?=
 =?utf-8?B?azI0WkJVUXRTNmZvdE5PUFVuUzlzVmlWaTE3M2U0Ui9TZm1xVFNENU1tNldv?=
 =?utf-8?B?Y2ZaVndDenJ5K1ZKNVluV3c0ZFpnUkNRWnNVMEs1L2tBQ1JUdUpvVVQvd0Rt?=
 =?utf-8?B?dW0zTlF5Nlg4eTdRc0I4MWdWL1Y1QkhwUEl1RDdQcjFUTWlzRFhjSFlTbjQ5?=
 =?utf-8?B?cFdzTVRScmU3Q2R5MmZyaXh6bzAyeE9mSmV5UVo0Z2xUbU12MGJMTGp5cS9W?=
 =?utf-8?B?d3pLMDF6YVFRSUhaUURQU0ZOUGRoTEl0TzJtT2pUWkE5ajZvd0dBN0xUMy9P?=
 =?utf-8?B?RDZDS2tzV3VuQmRVeG9zRzFaTGdidno5Y0FBL2x0dFdKM2xOZnI5U0dhVVdi?=
 =?utf-8?B?QVRqY2ZlcVdJaTZwZDJqczNUZlNMUTNrWWtINnZZb3U0Z3ozek4yV2hWd3Va?=
 =?utf-8?B?eHFpa3luUi9XRThybnhlZzZ1UFpPUlU5UTNqRkRvay9IVW9rZFQ2SXM3eFVo?=
 =?utf-8?B?VmZ6YkFnTFMyN3pzanFYV0VUV0dWbUxEeG1TRFlUSmorb1dQNmpBWGJYMk5B?=
 =?utf-8?B?L2lLYjl1SmdxaDlkSWF4U2IwRGkzeFRJMTRpTlNxTnc3TUM4L0IrQUZXNHQ2?=
 =?utf-8?B?di9ROVM5U1RjRkQ0WHdVaGN6aUFXcUxPNjMvUnFMbHVnYnA4M1V3cjdkTjZ1?=
 =?utf-8?B?RVhwRzFJc0pkU0dEUWhXdG13UG9ycWlIVCtpSFBpTnBuSGNzQUc5N3I2M25S?=
 =?utf-8?B?UU01OEtyZHpiZGN1QTcyN1FMYXp0NkZSSFBVb25tbWZNL1pPV3ljcHkxSXl4?=
 =?utf-8?B?N2tURVcwWUl1V1F6dGhPaVVHMmp6QmRqMENrOExKODV1SWFXemMvbC9IRmN5?=
 =?utf-8?Q?Jjq0rzBZvcOCcNxpG6oRa+FXy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc8dd16-27e8-4c80-6cb0-08dc5d3e5622
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 11:22:29.8325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iz7EOLLIKL37kO5owjT8H7NJMz/gNZRwNvixgFLiijEVurg0me6ZKIB1UOgvt20WnnV0s35H/F2GHk+IVBjlug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5805

It was Jon Hunter (jonathanh@nvidia.com), who identified the issue.
Credits to him.
I'm merely upstreaming the fix.

Thanks,
Vidya Sagar

On 13-04-2024 00:44, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, Apr 08, 2024 at 03:00:53PM +0530, Vidya Sagar wrote:
>> Tegra194 PCIe probe path is taking failure path in success case for
>> Endpoint mode. Return success from the switch case instead of going
>> into the failure path.
>>
>> Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> v2:
>> * Added 'Fixes' and 'Reviewed-by' from Jon Hunter
>>
>>   drivers/pci/controller/dwc/pcie-tegra194.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
>> index 4bba31502ce1..1a8178dc899a 100644
>> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
>> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
>> @@ -2273,11 +2273,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
>>                ret = tegra_pcie_config_ep(pcie, pdev);
>>                if (ret < 0)
>>                        goto fail;
>> +             else
>> +                     return 0;
> Wow, how did you ever notice this?  It looks like this path would
> previously have returned "ret" (which was most likely 0 for success)
> but with an extra tegra_bpmp_put() that we shouldn't have done.
>
> Eagle eyes!
>
>>                break;
>>
>>        default:
>>                dev_err(dev, "Invalid PCIe device type %d\n",
>>                        pcie->of_data->mode);
>> +             ret = -EINVAL;
>>        }
>>
>>   fail:
>> --
>> 2.25.1
>>