Received-SPF: pass (google.com: domain of linux-kernel+bounces-145043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Mon, 15 Apr 2024 14:11:48 +0200
To: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, haoluo@google.com,
	sdf@google.com, kpsingh@kernel.org, john.fastabend@gmail.com,
	yonghong.song@linux.dev, song@kernel.org, eddyz87@gmail.com,
	andrii@kernel.org, daniel@iogearbox.net, ast@kernel.org,
	martin.lau@linux.dev, khazhy@chromium.org, vmalik@redhat.com,
	ndesaulniers@google.com, ncopa@alpinelinux.org, dxu@dxuuu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
Message-ID: <Zh0ZhEU1xhndl2k8@krava>
References: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com>

please use '[PATCH bpf-next]' in subject

On Sun, Apr 14, 2024 at 07:51:24AM +0300, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
> 
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
> ---
>  include/linux/btf_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_BTF_IDS_H
>  #define _LINUX_BTF_IDS_H
>  
> +#include <linux/types.h> /* for u32 */

lgtm, did it actualy cause problem anywhere?

there's also tools/include/linux/btf_ids.h

jirka

> +
>  struct btf_id_set {
>  	u32 cnt;
>  	u32 ids[];
> -- 
> 2.34.1
>