Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474AbYAXNBS (ORCPT ); Thu, 24 Jan 2008 08:01:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753290AbYAXNBE (ORCPT ); Thu, 24 Jan 2008 08:01:04 -0500 Received: from hellhawk.shadowen.org ([80.68.90.175]:2799 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922AbYAXNBB (ORCPT ); Thu, 24 Jan 2008 08:01:01 -0500 Date: Thu, 24 Jan 2008 13:00:53 +0000 From: Andy Whitcroft To: Andrew Morton Cc: "Theodore Ts'o" , linux-kernel@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com, "linux-ext4@vger.kernel.org" Subject: Re: [PATCH 30/49] ext4: Convert truncate_mutex to read write semaphore. Message-ID: <20080124130018.GA11136@shadowen.org> References: <1200970948-17903-23-git-send-email-tytso@mit.edu> <1200970948-17903-24-git-send-email-tytso@mit.edu> <1200970948-17903-25-git-send-email-tytso@mit.edu> <1200970948-17903-26-git-send-email-tytso@mit.edu> <1200970948-17903-27-git-send-email-tytso@mit.edu> <1200970948-17903-28-git-send-email-tytso@mit.edu> <1200970948-17903-29-git-send-email-tytso@mit.edu> <1200970948-17903-30-git-send-email-tytso@mit.edu> <1200970948-17903-31-git-send-email-tytso@mit.edu> <20080123140659.5b70ae6b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080123140659.5b70ae6b.akpm@linux-foundation.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 54 On Wed, Jan 23, 2008 at 02:06:59PM -0800, Andrew Morton wrote: > > On Mon, 21 Jan 2008 22:02:09 -0500 "Theodore Ts'o" wrote: > > +int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, sector_t block, > > + unsigned long max_blocks, struct buffer_head *bh, > > + int create, int extend_disksize) > > +{ > > + int retval; > > + if (create) { > > + down_write((&EXT4_I(inode)->i_data_sem)); > > + } else { > > + down_read((&EXT4_I(inode)->i_data_sem)); > > + } > > + if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { > > + retval = ext4_ext_get_blocks(handle, inode, block, max_blocks, > > + bh, create, extend_disksize); > > + } else { > > + retval = ext4_get_blocks_handle(handle, inode, block, > > + max_blocks, bh, create, extend_disksize); > > + } > > + if (create) { > > + up_write((&EXT4_I(inode)->i_data_sem)); > > + } else { > > + up_read((&EXT4_I(inode)->i_data_sem)); > > + } > > This function has many unneeded braces. checkpatch used to detect this > but it seems to have broken. This is a side effect of this rule: This does not apply if one branch of a conditional statement is a single statement. Use braces in both branches. Basically each arm is being considered in isolation, each arm is seen as having a "sibling" arm with braces so it is permitted to have braces. Bugger. I guess I'll try and see if I can detect this. > > + return retval; > > +} > > static int ext4_get_block(struct inode *inode, sector_t iblock, > > struct buffer_head *bh_result, int create) > > Mising newline. We could check for those ... will look to add in the next release. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/