Received-SPF: pass (google.com: domain of linux-kernel+bounces-145228-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 40.69.19.60 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.69.19.60; helo=westeu100-emailsignatures-cloud.codetwo.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <cda9f2ff-d13f-4421-ad10-72ab29fa0024@topic.nl>
Date: Mon, 15 Apr 2024 15:08:01 +0200
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v3 2/2] power: supply: ltc3350-charger: Add driver
To: Sebastian Reichel <sebastian.reichel@collabora.com>
CC: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>
References: <20240409135442.37732-1-mike.looijmans@topic.nl>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.dab85cfc-973d-4930-8fea-324aa26b5801@emailsignatures365.codetwo.com>
 <20240409135442.37732-2-mike.looijmans@topic.nl>
 <5hpl2kspf667hmmxgg36ahiux5rs364qzrg2itpljspspa47vp@dsbnhdnq5s54>
 <efae4037-c22a-40be-8ba9-7c1c12ece042@topic.nl>
 <lxxwadaf2mrghy2kygm3cucb7ygl5qu4dxnmpbancrm2hwjm4g@5eudactyudca>
Content-Language: en-US
Organization: Topic
In-Reply-To: <lxxwadaf2mrghy2kygm3cucb7ygl5qu4dxnmpbancrm2hwjm4g@5eudactyudca>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 sU1NNXxnzZdk2uwIWSWwOLhqFubfBO9ISzakgI2hCt+k8Up7RwK89p+Ef/3pgxDxWEpLx7hd+MsUbWH4+7yjRSLy7FZe9ZGigHiW1shvVJWDCsDe+Ez/pL/JXPUqOtXKg+6wfcPlDGeazLDeLrCI/D8x3to7IgHrcQRwpfC+6z9taKpKAXFXW8uENmDshNCBbqTfKAxC81hho/1YHUnvjeXmiK4bCg78xiyyDR/MZhpP4N/SFEmlDpzgdS1XYgM4o3xkZ9d3YFhzpYQget0DSQte98EVM9wZgUZC5zJBRxbvwMESvV4u4Fg3FUvqSa2if+sNGsyXxmTvmMMHcw0mjaSlT1j3hVF6LlVmJ9Xbb9VTtPKOA6QiJ89ZRAm/A66wxmpkcBL8kZdipGFMyBrZ11M7YVt6GzwwgCaaZKMFmmvH8HTFdVjZoqRTBa7HcjnDmCfYEAxZ150SrcsZ3wVroBp2yQHQ6kRjWx6oQtYonD6udItqOIKqANlbawaHRBCjK3G8uO2yG63nADSxNAlQbBM13Fh2vKI8V5GZAj9Edkr5cNqvcRiiZL+4gCqSu9+IJDbOFy5q1ZMt5XPl0V3AU/xS1JTZjAJLoURrOtWP7spt79dDIj0B3kkhjyTmPzZHqaQhxeoI40hwTYqf+GOD2Lw4H3UxafkBtzQmQ6Zq5iQ=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(1800799015)(376005)(366007)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8908
X-CodeTwo-MessageID: 74090fe1-71e6-421f-98bc-f237d2f3e2d0.20240415130804@westeu100-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM2PEPF0001C70E.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	44c1086a-c4f9-48df-6c70-08dc5d4d1455
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZHpmRPx8zWfek9nyMvR5CeU8jtxCH6P9sTGBzoZkTyfbiZEY112gluGElgOybL6SA9p42gEHoxoNscBb+aTXecMDS+zmwxGD9Sf5K83RFmxeBzJzn3gLbfUbRoCZ1WKllyGaAmSuGWXHqJ5hdyMopUz2YHNAKAI8dcuGpGJRZvJqYhNcE8sRHpxwgxKF0ZhtinBh0qDkty33dEQnOoF8Z9ec01H50kET+Viczgiu9sCaRoar/yIH4kXySMKgfpZLG4N9LZrDNOCjynMjnvQs2VEHz3qUARDeUq2q+KfEd14S/rDbo1Z8htRDPWeH39LPZ1wBpTJo3uIVyJ9rZXfNn6CUOK4jvbCZhVa8vsQMd+lEBr2WB/BlZZXhQLJWDJ97z2ydPqP+NpP3CXswpiAseMGxf6hThVjGOIqZfD2B22BLcBBBRVLbTExEKxjXAxQKWLnHEmIC9c4iQTx1qE84ogKjCgezPK8PuCbrT+4qZ4nGZ2oerG17YQ4upjxYp59Onj2V+ZgBz8M6qKHFAQ9DZpP6TQoYq4Ot88Utl7vsNHJEhLBHhFqaOUdUOywmO30z3AwLQqZlwjnQPj4c2Ru3gscBjG6dZQlWkPSc64QRKyB3Jd4zIYgArqba/g41VhpdO1NsZsrk4mzBQKhSdfd/wG5uaylHd01EAeo8y9ZbUtHKbql8BdvenIfOXSU63ElUgKJDQ8awDNMJCJqh+bJXBw==
X-Forefront-Antispam-Report:
	CIP:40.69.19.60;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu100-emailsignatures-cloud.codetwo.com;PTR:westeu100-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 13:08:06.0120
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dc285e89-b9b8-4793-a220-08dc5d4d1717
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[40.69.19.60];Helo=[westeu100-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM2PEPF0001C70E.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8955

On 14-04-2024 19:29, Sebastian Reichel wrote:
> [+cc Nicolas]
>
> Hello Mike,
>
> On Fri, Apr 12, 2024 at 08:53:58AM +0200, Mike Looijmans wrote:
>>> please share output of
>>> ./tools/testing/selftests/power_supply/test_power_supply_properties.sh
>>> below the fold with your next submission. It's useful for verifying,
>>> that you got the unit scaling correct for the standard properties :)
>> Will do. Did a quick run on the driver as it is now, that yields the
>> following output:
>>
>> (Any thoughts on the "arithmetic syntax error" messages?)
> The script contains some bash specific shell extensions and should
> use /bin/bash instead of /bin/sh in the shebang. Just call it with
> /bin/bash ./tools/testing/... and you should get rid of them :)

Yeah, installing full bash (instead of busybox ash) on the board fixes=20
these messages.


>
> Nicolas, do you want to send a fix for that to Shuah with Reported-by
> from Mike?
>
> [...]
>
>> # Reported: '1' ()
>> ok 6 ltc3350.sysfs.online
> [...]
>
>> # Reported: '711600' uA (711.6 mA)
>> ok 24 ltc3350.sysfs.current_now
> So it's full, but still getting charged with 0.7 Amps at ~23V
> (i.e. 16W)? That seems quite high.

The "current" is also feeding the system, not just the capacitors.=20
(panel backlight being the main consumer)

I modeled the current into the caps as=20
POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT but in retrospect, that may=20
not be the right place.=C2=A0 Maybe that should be the "CURRENT_NOW" of the=
=20
battery component?


..


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl