Received-SPF: pass (google.com: domain of linux-kernel+bounces-145239-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Apr 2024 16:21:30 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr()
 macros
Message-ID: <Zh0p2vzG6h8M7Xpd@smile.fi.intel.com>
References: <20240412155830.96137-1-andriy.shevchenko@linux.intel.com>
 <Zhn0SgGulHq8Bbk3@yilunxu-OptiPlex-7050>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zhn0SgGulHq8Bbk3@yilunxu-OptiPlex-7050>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Sat, Apr 13, 2024 at 10:56:10AM +0800, Xu Yilun wrote:
> On Fri, Apr 12, 2024 at 06:58:30PM +0300, Andy Shevchenko wrote:
> > Since the driver hi6421-regulator depends on CONFIG_OF,
>                    ^
> It is ice40-spi

Oops, copy-and-paste typo.

> > it makes no difference to wrap of_match_ptr() here.
> > 
> > Remove of_match_ptr() macros to clean it up.
> > 
> > While at it, add missing mod_devicetable.h.
> > 
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/r/20240412151147.22a059ff@canb.auug.org.au
> > Fixes: 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")
> 
> Since 5d04660b29fb is not merged yet, could you just merge them into one?
> Or it breaks bisecting.

You can also fold it, but sure, I'll send a v2.

-- 
With Best Regards,
Andy Shevchenko