Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1436342lqp; Mon, 15 Apr 2024 06:40:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXVFGbR5sd0eXdDCOx81qFDjoHpNAmooTKCbxQcn3T+Xvn9P88+mGKeF6a1qhMRLfZLVOP9TsYzzy/HmO2woEYfQgNMoaKq0y7A09otJQ== X-Google-Smtp-Source: AGHT+IFhKOCfBvdMc13J5DKC6fpNI+wHAFBtmI0+DsKbplRM65iLqotr9TtGpZ+ClxPhErtq2oa2 X-Received: by 2002:a05:6512:2506:b0:518:9ab5:a987 with SMTP id be6-20020a056512250600b005189ab5a987mr6227327lfb.18.1713188430722; Mon, 15 Apr 2024 06:40:30 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m17-20020a170906721100b00a51a070b749si4447290ejk.421.2024.04.15.06.40.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 06:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b="PY/xEU9Y"; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-145272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145272-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 367A71F25A39 for ; Mon, 15 Apr 2024 13:40:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65F61823A3; Mon, 15 Apr 2024 13:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PY/xEU9Y" Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8608063C; Mon, 15 Apr 2024 13:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713187949; cv=none; b=l+lyvXBSyIa+x9FF0y1it1aXHQsaaixLeXHilVvZNZQ9Erz3jyOBeN7IbH1GRkylSu6nB3wc//B0IGWgbmahiSnS+7V9XEUoOoParNdrI0f4GFhnHGOTxcdWyBrqyxyq7U8fFCK1YQ67YdQ9W2srHzbwW9e71FtkLH2k1xwtf9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713187949; c=relaxed/simple; bh=lY9dhM6iK8H+xRTcxtbZNqjoO3E0/X10GLrYjtfX2BM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rBeFUmiB5mUKBkF4Dak/rwabJhCcXBChif6rH9nWeKPNiPP6J5+GtDiRT/xyqV7i6zkaHv62lfrzsAXb92/vtCD4kJP/ybqo94bGfDd2+UjMEHMfNAEGOGk2silrC1EZtzAHVpOfz5RQvJtoYEzUP3TA6lPOWHibCmi88sUi4eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PY/xEU9Y; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a46a7208eedso457622666b.0; Mon, 15 Apr 2024 06:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713187943; x=1713792743; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lY9dhM6iK8H+xRTcxtbZNqjoO3E0/X10GLrYjtfX2BM=; b=PY/xEU9YdR31luxBgHMkxKtZtAEIaAIlw7e51YwKSf4rH30O3iZJQFMCEbQ9xT5/rc SXl3oCVS41LsBRR7wpFXmQh6zznxfJ4lAgzQWbwe+nvv0piAQj7lbMrSVi7gQeyaV72B mFU/u+iQKbg82Pa6PnvM6+dhJx58HAS2Eg8ccA/s0/LJr+tvjhHKXeRL4MAnyuQ969nZ zM5DRfA5tETmqMnGQU7A7MY2EwksJnKt0A1pYNCZYYuorH20ryQBTxRFt6d/6jx8oZwh CQmsxQp5C8rFXPBTWrMeUVWWZznhqslI6erqNSK2sIa2wkV1r8PJ6UwhjHOBfHLWYPk1 gZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713187943; x=1713792743; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lY9dhM6iK8H+xRTcxtbZNqjoO3E0/X10GLrYjtfX2BM=; b=OP9c5KJzk4qClCY2GAJVNxjyxpTYCO6DFoK408X9+Bkaw7d4LmF+ikZ18uliMDUC8f MZuOa8EKan/SuSihbyJUCMUfW60IJNJh0nZCIav3I268Rpbv8rfu0FbE8dVqZ9MzCaVw udRzqKKC4jpj5e4yXEqLTQ64k/BiL7fQI6uA3TsnDxPDLeeMwvWzZrhiBhWchURjLdFV DwK0q3UQkcPlK46Xwuwk/q9FIIjihGDI/1MdkBqwTUH3TqUdowILiUU9VSXzKm1dPfl0 DXtxdkUcBv5t8ilRKskaOJRXTJolLX+Pxbz0CSj9ClxH1xGgeBycDT9gZDdp33yOPDiD s86w== X-Forwarded-Encrypted: i=1; AJvYcCU/LgmKnlCjjwpRU55L63uijLtlTQi0xXyNw9HB98ykesNcxVeDmI+2tFuFHBMeua+BmbUTOOPuB99rf3j2LLTBJHlzuef8PBuZn7q03fp22eY8LLZTiHJaGZwxhay3RSuhXORzjM230nOgg/UPJZBY62agddac+yLi0hOnmP55VSnzxA== X-Gm-Message-State: AOJu0YxsaN2srAxH8SoGnkQvnP9l8E/bCi2GhaTAZH9ccP85Rbcfc4xj WGGY6PetHWDX6JRZd2rX8ebXt9CIdLp0EThFatsGmNOe5FYUqBx0ck3W9HjsAXftj9r7Lm0mNEf j0xD2JKfCMIQSxBLQwY3yqsAAPETuCXzAJ2g= X-Received: by 2002:a17:907:208f:b0:a52:6b12:3078 with SMTP id pv15-20020a170907208f00b00a526b123078mr1637121ejb.55.1713187942584; Mon, 15 Apr 2024 06:32:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240413151152.165682-1-alisa.roman@analog.com> <20240413151152.165682-6-alisa.roman@analog.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 15 Apr 2024 16:31:45 +0300 Message-ID: Subject: Re: [PATCH v5 5/5] iio: adc: ad7192: Add AD7194 support To: David Lechner Cc: Alisa-Dariana Roman , michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexandru.tachici@analog.com, lars@metafoo.de, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Apr 13, 2024 at 11:05=E2=80=AFPM David Lechner wrote: > On Sat, Apr 13, 2024 at 10:13=E2=80=AFAM Alisa-Dariana Roman > wrote: .. > > +static int ad7192_parse_channels(struct iio_dev *indio_dev) > > Better name might be ad7194_parse_channels() or > ad7192_parse_ad7194_channels() since this is specific to the ad7194 > chip. Quite unlikely we have the same chip to be supported by somewhere else, so I would just name it simpler, i.e. ad7194_parse_channels() --=20 With Best Regards, Andy Shevchenko