Received-SPF: pass (google.com: domain of linux-kernel+bounces-145274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b8236348-476d-4c50-88ab-0409e4bf6bf0@redhat.com>
Date: Mon, 15 Apr 2024 15:35:33 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] add FnLock LED class device to ideapad laptops
To: Gergo Koteles <soyer@irl.hu>, Ike Panhc <ike.pan@canonical.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
 Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-leds@vger.kernel.org, devicetree@vger.kernel.org
References: <cover.1712063200.git.soyer@irl.hu>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <cover.1712063200.git.soyer@irl.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 4/2/24 3:20 PM, Gergo Koteles wrote:
> Hi All,
> 
> This patch series adds a new LED_FUNCTION_FNLOCK define as "fnlock" and 
> adds a new FnLock LED class device into the ideapad-laptop driver.
> 
> This helps to display FnLock LED status in OSD or other places.

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> 
> Best regards,
> Gergo
> 
> Gergo Koteles (3):
>   dt-bindings: leds: add LED_FUNCTION_FNLOCK
>   platform/x86: ideapad-laptop: add fn_lock_get/set functions
>   platform/x86: ideapad-laptop: add FnLock LED class device
> 
>  drivers/platform/x86/ideapad-laptop.c | 133 +++++++++++++++++++++++---
>  include/dt-bindings/leds/common.h     |   1 +
>  2 files changed, 123 insertions(+), 11 deletions(-)
> 
> 
> base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f