Received-SPF: pass (google.com: domain of linux-kernel+bounces-145260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 15 Apr 2024 15:22:49 +0200
From: Johan Hovold <johan@kernel.org>
To: Kenny Levinsen <kl@kl.wtf>
Cc: lma@chromium.org, benjamin.tissoires@redhat.com, dianders@chromium.org,
	dtor@chromium.org, hdegoede@redhat.com, jikos@kernel.org,
	johan+linaro@kernel.org, kai.heng.feng@canonical.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	mripard@kernel.org, rad@chromium.org
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to
 power-up transition
Message-ID: <Zh0qKeI-YPDE-NVT@hovoldconsulting.com>
References: <CAE5UKNqufWZfKLAXLcpBYKQpJEVt6jPD4Xtr=Nesh34VkNOETg@mail.gmail.com>
 <81e1b870-37f9-4ef2-9a3d-87015f32546b@kl.wtf>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <81e1b870-37f9-4ef2-9a3d-87015f32546b@kl.wtf>

On Mon, Apr 15, 2024 at 12:28:28PM +0200, Kenny Levinsen wrote:
> > The problem is that the probe function calling i2c_smbus_read_byte()
> > is not aware that
> > uC on the other end is in a deep sleep state so the first read will
> > fail and so the whole probe.

> Well, the probe was just added to "avoid scary messages", so we could 
> just do away with it and fix the "scary messages" instead.

We also use it for devices that may not be populated (e.g. an optional
touchscreen) and in that case we should not print anything.

Johan