Received-SPF: pass (google.com: domain of linux-kernel+bounces-145265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 15 Apr 2024 09:30:24 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to
 variable ret
Message-ID: <Zh0r8FXN45ThNLwk@tissot.1015granger.net>
References: <20240415100713.483399-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240415100713.483399-1-colin.i.king@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?md/Q3ekAANxJZuOf1O6RQHkRlGd8c0p33U5ezkK1CmKKSj/6nJm2Clq3Nf9Q?=
 =?us-ascii?Q?Dr/E/filltfsGL79eDw5InOaC41eeoaJULrOBqSUau3+MoB3QxWzeUCkVwVW?=
 =?us-ascii?Q?7eE6Q7RaPZOK2+hvAEwm6WXiIdrYSN1RBCwKP/PpvEJDZfZLXhSDL0BPiaq5?=
 =?us-ascii?Q?ff6krjEjAuHmQ0iecuYitasSnG8a0EF1pPbO77RheORVsdZrFkHgHn4nRdEM?=
 =?us-ascii?Q?vYXtEYplRluErcOLIUZUWGKQ9q3Dp54jkr8EzhKEcWJWdgCRztVbIcsAjfPt?=
 =?us-ascii?Q?YDDF5iuB64k5f/JF0bcCmjfkGmTzGDp2xJWP9x87X6kGXpr1g6RbaQ8/IF64?=
 =?us-ascii?Q?S4VRrHUas6QD31NZpVFmdwMyXJnI3u8AIV/G1dCHbfF1C2muy+H9lxO6R1f8?=
 =?us-ascii?Q?tkRFjw1zMPP6Vu1K5GaT5S26mqkcBX/Bx2j3tOi4t5JOP6E4qRizvMh0QsxV?=
 =?us-ascii?Q?BuesadsN3sIJzObIqOg2f+rcWbX4zJYhLPL5gUpl1UEJ1D1OTrjz7Favv4dN?=
 =?us-ascii?Q?+SDvyh/fH+umoe/1cJXfTt9/MtTB5xj4z4+5iNJROPfoGRL1KiQdK3ovZzef?=
 =?us-ascii?Q?rg8B6SZZG5LDocFTstByO6+8eFLqE/Jez509KeVw/6OMUou/ObSDFIKivJ16?=
 =?us-ascii?Q?Gn0HKAorb4jFhWYABHdmpj8t7lMJhDOW8RMEZ1Nl/8XXzsSnqymiRHFiWWL9?=
 =?us-ascii?Q?ZrzMVysZhaKMEscuypETwIEBT12JGbWBpD7FIPBW0iGg4QdDti02xPBQgZTU?=
 =?us-ascii?Q?knB3ej8IesUnqcxH5CsPZCL+zdGYdH8L2+mljALU6aHIK6aI7ZoDD/VxLv7q?=
 =?us-ascii?Q?/92K1HpGcbXZLNSyzilcA5HSYNLJ1VARthRsmkIDqc4jvZSqXxdfiPnAy2dc?=
 =?us-ascii?Q?IjPBFFcVdM18wMvmwLuomubZyPBzRbJT2cwE7IWQ9ioRdFGuU2ThD6Q0wDut?=
 =?us-ascii?Q?1Uzx8e1+UgwcXcNzUmseY4PkKKgrM/gP0Go1aeGwX0mmrE7lRfG9E+tv56bP?=
 =?us-ascii?Q?jNcKgOYS46Haoa4OTDdyqiSRb+x3R0OQNMI0nFSgD421wTzScG560aM+Isoc?=
 =?us-ascii?Q?jYruVqY52z35InBPXQrDqZcB38rqKzFLwNKTjj35cleRn7SHKyyMwmNJK8n1?=
 =?us-ascii?Q?loJ+oVHTJrO0SEDdgLFCJVkO4SgeN0Y9kLdJ4fYPyOxcJbR6sJ/XONrlMPBd?=
 =?us-ascii?Q?a+q+DwfATnWiP80A3TXhekDUQzX6BcFftdFICvYmq7KrOQdtl5nkq50Gegx5?=
 =?us-ascii?Q?+2+Vd+mxOXsfUlt2MhMH5c2cXoUXOFvIPObUZ1B8NJ27m0vtpyql6QHB7DAc?=
 =?us-ascii?Q?5m3fg7JmpP7zmctEtRYF8KqVyTclSGGbQjO3coIU53AwnXZuzxRfJ8VrJ6mC?=
 =?us-ascii?Q?Bu+jI9E6yqjpoD8XLltCDP20kC7WbDYCgkvFaux4xOhnU40HCanEJxogMWPx?=
 =?us-ascii?Q?bs8oJO073YSWW+uTKOWQJwu8mn7G0Yu1GUfkAPz3d0n+vSILujmXy299erx2?=
 =?us-ascii?Q?xW7QvbOx+KDL/tCF9uEvjr4brAwpZ5Lng0YxizEL8+aUAkAX3NGSajm0sD68?=
 =?us-ascii?Q?zPIYVV1l8FN3FkjFmN/QRWaDtHAxYwUlKCDkRTmcxc86jWkeXLTMBGQ/W8sd?=
 =?us-ascii?Q?Xg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	M1nKWl8TzPhAJctsuHz/qjssxse/8W53Cz4gugbze60AmjZULNERbpiExM4xbHG1ILWl3iwmsRENcWH8yC1f5ZRLadBkWa8KCF/bcxWYzkTU1bW0Wplq39gU2pc6QF0YUKyiW/wxsDBZAYejRi+Dd7HBH0MOWpN0co34Tfz9LTLTqnSQbDoM8fI51sOyvNRe736Z1HoScn038vEsGTomH7vm7ghbbDyzcPt0/B9pzmt5fIBn0onvvSHqI+AfJIdErSgr3ui0ekN5KPJiLYf51CawjOxbBLCxKl0YNEqKlmXOxSyq5NAkt/wzt9++naiIzGhsueFaioaInI2PyX0aG+iXRWmbPI86E+ebyqK/51o/x5tOsmcxwQGEYRKNtzAM5GVylZ9HblIb0gr4VLmvAylVkTAUq4pIYIrxBkadUhDplQsuSpPsGs+P0YJzwAtb9+WikVq9C3WnpcpUgwZcN6Sx8/PTSGI/yW3fW114jgalWItaiwC2AAjy7TpBNU319dhR95O5FEAaWEdtF7KW3dfHXhb+v5xcLJ9BjIAXcQFN99Ac1Xfo83ecuKo30G5Topl+KSSjC77JpFs4kRqTfqvey/HiUY5MKnNpX1fYsRs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3303ca9b-4692-443d-92a8-08dc5d50369a
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 13:30:27.7990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mnWXTO/5+1ZMpWzFut3llO1mBguG8ZyunS8mCDfrggEotVK5xDxUuUTjbYl35zy3vdryPxWk1X1d9L3BBS6bBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7773
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-15_11,2024-04-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404150088
X-Proofpoint-GUID: ds4nb4Vb6o5mlVIEDwLL3jPiDnqnIP5H
X-Proofpoint-ORIG-GUID: ds4nb4Vb6o5mlVIEDwLL3jPiDnqnIP5H

On Mon, Apr 15, 2024 at 11:07:13AM +0100, Colin Ian King wrote:
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
> 
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  net/handshake/tlshd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c
> index d697f68c598c..d6f52839827e 100644
> --- a/net/handshake/tlshd.c
> +++ b/net/handshake/tlshd.c
> @@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,
>  	if (!hdr)
>  		goto out_cancel;
>  
> -	ret = -EMSGSIZE;
>  	ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd);
>  	if (ret < 0)
>  		goto out_cancel;
> -- 
> 2.39.2
> 
> 

Acked-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever