Received-SPF: pass (google.com: domain of linux-kernel+bounces-145268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 15 Apr 2024 09:31:24 -0400
From: Peter Xu <peterx@redhat.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, willy@infradead.org, david@redhat.com,
	lokeshgidra@google.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] userfaultfd: remove WRITE_ONCE when setting
 folio->index during UFFDIO_MOVE
Message-ID: <Zh0sLJfu19ij2rAV@x1n>
References: <20240415020821.1152951-1-surenb@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240415020821.1152951-1-surenb@google.com>

On Sun, Apr 14, 2024 at 07:08:21PM -0700, Suren Baghdasaryan wrote:
> When folio is moved with UFFDIO_MOVE it gets locked before the rmap and
> index are modified. Due to the folio lock being already held, WRITE_ONCE()
> is not needed when setting the folio index. Remove it.
> 
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Lokesh Gidra <lokeshgidra@google.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu