Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1455271lqp; Mon, 15 Apr 2024 07:08:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVKnMzF96spkURqHq+HXPifGDLADovqcLpwDer+bbMVwjWibuzXcSHfB7/ZcIvGWgMov8igzP9NDI4CGuQZvirc1h+zZqzPKruo/xRN6w== X-Google-Smtp-Source: AGHT+IHalxPYA79UWGvbKKQ/EKJobcgWJnMzX/i8xxyFW1lVQJzUR0GTiK1ybYO6zohq6tQrVezj X-Received: by 2002:a05:6870:b1c2:b0:233:f91c:436f with SMTP id x2-20020a056870b1c200b00233f91c436fmr9253355oak.48.1713190089576; Mon, 15 Apr 2024 07:08:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713190089; cv=pass; d=google.com; s=arc-20160816; b=at4JeaDyGX1pCg/cB6gHIMjYy8bIZYkMXia9BldgFYwssAjz+CB3iEeZDvnNK3tE9g KYtp6+/lXW+8b6RFvvX6Zz1MUGvrkCzgqDp7RT5NlkFM2SZ53wvY0UfsdXoGQrlBizKf rDzPlJeoM85Bs4qtNVvd3vnFxiC+RcgBmVsuTcGJZas6XT3Virt4GawSuOrmOJc0Y/as Jwk6wsy1aLFE0xk1ZPjYrdhyRXfu1o1ubYFk9zh2BwN6ZLyN33qcdGGldbkDjkkrPxEV RM1hfWaOCARc5+vF+zJWNRou+pYrYaFa7kLxH/VXY+j8U/GlOwHbvrA4VnlyJ454ztdQ I+oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=0bWmx/W7Q4K65bCAac1xpLoJfi541LZv2MZDkukOXDY=; fh=ec4Viid3DHG5kVULaGI/HHAnO/bKFshg8F6HffZK5MY=; b=Wu+t+CXr69QQi9iMpyWs1beBY1d4Ptmnsqz7N/w5xv13+7GhGsFChZAujHISGFRD70 8mbxYsJZiWPE55XntOnjYJrojHn1dWwseVOuLJeL1Qsvd08M2dBuqu1z7qyIgsEDvyG/ WzxHeTIayLeDFfR/4yItwcu1zxa3Ut0pwGSYh0YPJAcCiEXcBy1711YEOgYLmnukiw/S LSx57KPoshOajLsYuTpB9eSmROyV47lENcspP37RBHw7thfCJe57tk+HVaNPNRQaTXTv lCIdmTYcJfynbJe8naS0pVYfyM0Ru4u+u8HH24wP34eAHe8GoTTwY+viE0+QFfWPXLU1 VZKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H+jUHZQb; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-145322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d19-20020a05622a05d300b0043282c25b88si10211011qtb.391.2024.04.15.07.08.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 07:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H+jUHZQb; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-145322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 15D341C21E1A for ; Mon, 15 Apr 2024 14:08:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1294C757EF; Mon, 15 Apr 2024 14:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H+jUHZQb" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE00474E3A; Mon, 15 Apr 2024 14:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713190074; cv=none; b=pdpBnCA3J9JRckS+dXyzTwNA/pmzdrLc4/G7xqT57PyC4AoKvW8X0lsM6Mm2dYnjyfPK0oPz7Ur4t5Ni/KWCWv5hSU0vbziC1Z2Wq0NqqWrwjNwul4ALYdG4/hSCER/zePN/thpG6AmGS/axzTd7nA0ol4w9mUF2VZk03viOK1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713190074; c=relaxed/simple; bh=iLpEtGtKkckJoSs3revBB/GVNqg1O8LlmWFpE7x+CWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nDyHtd8BArPa1YWqafk9yIzaz3ByHYQQRUY4eF+LwnSKQSxG3vMgG6SEThpLE+ITTtfyLy6hKMiSLgcqYoQXHrSQUElI3wVUDfB94P1swESPCL+Y8PGWosvvCAsRLoqx31SJogyeO8sZJkT+crv4B3QRO8qU41lOGQg3nTAMrok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H+jUHZQb; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713190073; x=1744726073; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iLpEtGtKkckJoSs3revBB/GVNqg1O8LlmWFpE7x+CWU=; b=H+jUHZQbl3oDXZSyPUdHKLRVTSlVXJ75+2YDubSQJivOOHAPRcRKXa8z 0d/zYA3xDpBhp77mdGFXjcNGpspIS1d3ryUMKmF5M9oXJNix1Sy1xWOxH iwKyvZ7lc++aD86RffWy0/A0PzHEMDIqE2cGqvzYp/2Oi7tbZXYPcIqFs GF17NBLJ5R2wF5fA729XSbhIwj54/4E+sai+lmfE196VulXcPTxuTk+1K /VBskPWr3+67pT5pyHYAhtI4SQx5IocXwNF9PmyK2CYUIh86sDs8dQ5hD tl/aZ8A/GUJa2YLjjU4O8CchAEVzMsdnTFdNnIcF7E7XQlHibRoO81V01 w==; X-CSE-ConnectionGUID: EbXiUeQrTzi7WrBh0/N4pQ== X-CSE-MsgGUID: g9+l/fhXSwCQzryM4OTlIQ== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8415926" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="8415926" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:07:53 -0700 X-CSE-ConnectionGUID: COIgAGrNS2iRVj55sVt0fA== X-CSE-MsgGUID: M3lwDkRlS8qtp/Yw0mR9sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="22399383" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:07:51 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rwMzs-00000004Qby-13lO; Mon, 15 Apr 2024 17:07:48 +0300 Date: Mon, 15 Apr 2024 17:07:47 +0300 From: Andy Shevchenko To: Raag Jadav Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pwm: dwc: allow suspend/resume for 16 channels Message-ID: References: <20240415074051.14681-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415074051.14681-1-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 15, 2024 at 01:10:51PM +0530, Raag Jadav wrote: > With 16 channel pwm support, we're registering two instances of pwm_chip > with 8 channels each. We need to update PM functions to use both instances > of pwm_chip during power state transitions. > > Introduce struct dwc_pwm_drvdata and use it as driver_data, which will > maintain both instances of pwm_chip along with dwc_pwm_info and allow us > to use them inside suspend/resume handles. FWIW, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko