Received-SPF: pass (google.com: domain of linux-kernel+bounces-145324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5bf08002-f1b5-46d7-be48-c81fde16906a@redhat.com>
Date: Mon, 15 Apr 2024 16:09:21 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4 0/9] Intel On Demand changes
To: "David E. Box" <david.e.box@linux.intel.com>,
 ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com
References: <20240411025856.2782476-1-david.e.box@linux.intel.com>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240411025856.2782476-1-david.e.box@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 4/11/24 4:58 AM, David E. Box wrote:
> Adds driver and tool support for a new "current" meter that allows reading
> the most current, but not attested, value of the meter counters. Also adds
> fixes for the intel_sdsi tool.
> 
> David E. Box (8):
>   platform/x86/intel/sdsi: Set message size during writes
>   platform/x86/intel/sdsi: Combine read and write mailbox flows
>   platform/x86/intel/sdsi: Add attribute to read the current meter state
>   tools/arch/x86/intel_sdsi: Fix maximum meter bundle length
>   tools/arch/x86/intel_sdsi: Fix meter_show display
>   tools/arch/x86/intel_sdsi: Fix meter_certificate decoding
>   platform/x86/intel/sdsi: Simplify ascii printing
>   tools: intel_sdsi: Add current meter support

Note the subject prefixes of these last 2 are wrong and should
both have been "tools/arch/x86/intel_sdsi" I have fixed this
up while merging this series:

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> 
> Kuppuswamy Sathyanarayanan (1):
>   platform/x86/intel/sdsi: Add in-band BIOS lock support
> 
>  drivers/platform/x86/intel/sdsi.c      | 118 ++++++++++++++++---------
>  tools/arch/x86/intel_sdsi/intel_sdsi.c | 108 +++++++++++++---------
>  2 files changed, 144 insertions(+), 82 deletions(-)
> 
> 
> base-commit: 4cece764965020c22cff7665b18a012006359095