Received-SPF: pass (google.com: domain of linux-kernel+bounces-145402-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 15 Apr 2024 22:56:28 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 4/8] cpufreq: amd-pstate: Remove
 amd_get_{min,max,nominal,lowest_nonlinear}_freq()
Message-ID: <Zh1AHC7anVtP+pRk@amd.com>
References: <cover.1711335714.git.perry.yuan@amd.com>
 <c80c43cb72f7f9264edc21636d457c32d21de214.1711335714.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c80c43cb72f7f9264edc21636d457c32d21de214.1711335714.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?55zNnI9pgCMCZDCcJdhS+NYbSeNGzV7TtvjTHCSttbJNfQmLOC+VFijag1vC?=
 =?us-ascii?Q?9dxivOiu7ocrb7IaGUoufHQAZrw8N3DxxoNN8Wd/WamzqYBZvaeYmBNHx0Ha?=
 =?us-ascii?Q?MhZCWSK4HryWfhRUHqnsKq5qOg3qQ8dlo6KfXakXEeS6el53lyzxRnsxyVRZ?=
 =?us-ascii?Q?3ABWrcT5RXonGAEZTZY0RL4YiWMvppk5moIgGAYAZjTew96LT3evPnn3pWfG?=
 =?us-ascii?Q?xqF+9X8Y+ub8ZwvuqVYGRu6rOfoItKpd2MbZwMnUScSh4NDMRFllI3fYuesL?=
 =?us-ascii?Q?efrgdKbmLqm8U4Jy6u0Sn/t0F6uLmPmX1azEoXrmx6WLj7n5t5QJdWVTHSTC?=
 =?us-ascii?Q?li9j5MEYJqgVIWtu7AglXKqtRJtV0ds9Wr2lzjdIkQsrgq00GPQeVUuGHj3S?=
 =?us-ascii?Q?bIX4BfuW6J6hggM6AzWVZlIrBC+Oiybdb1va83rpxhrQ/4ca6FG+KBd+8Fn9?=
 =?us-ascii?Q?vpInb5GwDevG4k/mznhNzQfAcKS8Mo4A78P0lvZ75ffJxD77UPDDiH0lO1r/?=
 =?us-ascii?Q?C8gLI8g/3QU4kktkSf10hufTTmrZhzirmG1En02MEgEQiiaNEoqvdOAdHzx4?=
 =?us-ascii?Q?VS5vopExrggF9LwW8eXKOwKP5huGjhcGfTxXP9rG+pK64dp8dGgkSS3DmLwS?=
 =?us-ascii?Q?fI00ceG7K9k/X1pVDvZk1qXdK05B/0FZWzQVjqeMP6mCdNz4WwSK4GBPMS6+?=
 =?us-ascii?Q?UUTj0swd9B41J3pAZ8iEjJTUhaqI3Dod3nX+RrKUO/s3ELjhfrDalVGpF+ZX?=
 =?us-ascii?Q?AB6VTJKPYfQxL5CHq2ohMJnLfkcfV38WLvKVR9opcHMDR3Or8KM2Cih0GGXM?=
 =?us-ascii?Q?yWxFjnpP8ZU3ZNEJBY3ZIqvl58a1f+Jn66RLtNVZXAsWGdJ6+J4SqPEU61ga?=
 =?us-ascii?Q?CYuhONGywemEMrwNTP+9H8FMYrIak444uJ+F5M+dDcIpommUOopmrXVZjG7S?=
 =?us-ascii?Q?YxiDmtvX4jhbqBm+jdxmCtaglCEkrBWi6EvoDpTQb0Upt34H9sbdFXjEzRF1?=
 =?us-ascii?Q?Q7B73FV5vcErzozJdW+wXfFpysRxvRaOtxmJJo/mlYCT4CTIdnXyiUnjRvYJ?=
 =?us-ascii?Q?yphcWFo1xWoUq+mZrjP5WFkX0xpfqYpovKsRUGX6fv1anFA2XPH1IYQAZcYG?=
 =?us-ascii?Q?t0j4uRlACqprL3KwgTLoQNSmGAMhfn7IeQ5OA0sOH36NMGh0eGG+Wp09oR0/?=
 =?us-ascii?Q?r2HTi2/KX7NvELuseRZdlLfu/6s1SSMeVLuSK9JQWD2Xscc8/T0u0ahwaU3u?=
 =?us-ascii?Q?pSR19HkwZK0SFMaf8b/yaeyrP3MKouy6ydxbkax0yCRixu+bExe5APWEbcC/?=
 =?us-ascii?Q?Cq5p9DeEF626HRUMp1VLxgVAWjpB5oYE4CtFje2w7XbqEFTSByPaX0ULZ9Yc?=
 =?us-ascii?Q?ZWyxhtZZ4aoRgyIuxbYzArHrncfqbRXu96XaWzcfgHdmZEUahFjdJuZR1o9K?=
 =?us-ascii?Q?D3skQELwJGbCOz/6VM0LnVRiuumC3OFnwS1QG0Ev+MaHkq0a9BXYATRnxHtc?=
 =?us-ascii?Q?aqrD44/ftBXmmEF8VwLHSdHYkZjj/zI1EeOD0TGj0j2klmk2lT/GS7WQse9r?=
 =?us-ascii?Q?MlUnF8daDAkJqWrNeiaekFGFAmCoPQ/DBNIeLFAN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a177dda-3b78-415f-cd5b-08dc5d5c4767
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 14:56:49.8331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 62fubVfUZHrovU5PJqX5WvGRcMvk+btYjbGUrW7Uy4Q3Y6qtzZG+yxyGTs8sXFgq2oUpIsVMgOZ3zP9uWBTrag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9330

On Mon, Mar 25, 2024 at 11:03:24AM +0800, Yuan, Perry wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
> 
> amd_get_{min,max,nominal,lowest_nonlinear}_freq() functions merely
> return cpudata->{min,max,nominal,lowest_nonlinear}_freq values.
> 
> There is no loss in readability in replacing their invocations by
> accesses to the corresponding members of cpudata.
> 
> Do so and remove these helper functions.
> 
> Reviewed-by: Li Meng <li.meng@amd.com>
> Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

The same comments like patch3.

> ---
>  drivers/cpufreq/amd-pstate.c | 40 +++++++++---------------------------
>  1 file changed, 10 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ba1baa6733e6..132330b4942f 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -604,26 +604,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>  	cpufreq_cpu_put(policy);
>  }
>  
> -static int amd_get_min_freq(struct amd_cpudata *cpudata)
> -{
> -	return READ_ONCE(cpudata->min_freq);
> -}
> -
> -static int amd_get_max_freq(struct amd_cpudata *cpudata)
> -{
> -	return READ_ONCE(cpudata->max_freq);
> -}
> -
> -static int amd_get_nominal_freq(struct amd_cpudata *cpudata)
> -{
> -	return READ_ONCE(cpudata->nominal_freq);
> -}
> -
> -static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
> -{
> -	return READ_ONCE(cpudata->lowest_nonlinear_freq);
> -}
> -
>  static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>  {
>  	struct amd_cpudata *cpudata = policy->driver_data;
> @@ -854,10 +834,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  	if (ret)
>  		goto free_cpudata1;
>  
> -	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
> -	nominal_freq = amd_get_nominal_freq(cpudata);
> -	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
> +	min_freq = READ_ONCE(cpudata->min_freq);
> +	max_freq = READ_ONCE(cpudata->max_freq);
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);
> +	lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq);
>  
>  	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
>  		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> @@ -960,7 +940,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy,
>  	int max_freq;
>  	struct amd_cpudata *cpudata = policy->driver_data;
>  
> -	max_freq = amd_get_max_freq(cpudata);
> +	max_freq = READ_ONCE(cpudata->max_freq);
>  	if (max_freq < 0)
>  		return max_freq;
>  
> @@ -973,7 +953,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
>  	int freq;
>  	struct amd_cpudata *cpudata = policy->driver_data;
>  
> -	freq = amd_get_lowest_nonlinear_freq(cpudata);
> +	freq = READ_ONCE(cpudata->lowest_nonlinear_freq);
>  	if (freq < 0)
>  		return freq;
>  
> @@ -1315,10 +1295,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  	if (ret)
>  		goto free_cpudata1;
>  
> -	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
> -	nominal_freq = amd_get_nominal_freq(cpudata);
> -	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
> +	min_freq = READ_ONCE(cpudata->min_freq);
> +	max_freq = READ_ONCE(cpudata->max_freq);
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);
> +	lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq);
>  	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
>  		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
>  				min_freq, max_freq);
> -- 
> 2.34.1
>