Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1491125lqp; Mon, 15 Apr 2024 08:01:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWut9m/nIb9Dz3XSP/2sIzJ+tU7X1wkJysh3Av8hQlMxK1C4LJBhzjYfi4Do5+NoOwPRjtjqCt+yIpIMqbrVEHddsuiGgxZM5wSbsZvag== X-Google-Smtp-Source: AGHT+IEfasxJnN5s2/4uTcNcxzQ8a3a9djC7YC2/pZPAwiQChTVcBv3Qk2KFyYDJQCLzDCkcggfZ X-Received: by 2002:a17:902:cf10:b0:1e4:6938:6fe2 with SMTP id i16-20020a170902cf1000b001e469386fe2mr15067822plg.57.1713193312472; Mon, 15 Apr 2024 08:01:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713193312; cv=pass; d=google.com; s=arc-20160816; b=SXU/CXABQjRza0FbbObXp1T4bGlEvkxDjCUH9VH8CdJQwvDQytdUx2uvhT8d6f9Wat HCpiPhOSzuFrpxCXZYDhmFTKPSr2LJ+KUHg6zcbiR9TRPrnYTwEEOHjGssVQaA3soNyt JgDmo5xnwk1CiIAPB5eQg7v2UnFrlE/tkhIq3ArwkmxqLsCvhygreLQnrIshMpcck8Cn G9duHn5ZVPkvjGVMzcM9mirCimdKLT31oKVg2wIUyZ5hTk4eUSSCXstGwdOlttAK79Pc TzPHtz23JvT4E6sgF5atpgkEWmok453dI2t6myf3dmCibYG5CljdJF8vVWP9FVHQnzEW Zr9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; fh=RZNY7+ZH9HIexmaeAhtabHIQpv6PG1GfI73CWCRUXvI=; b=YLc3aDb1q5lTjKG5R3KuDEbgk27R780YYuIH18so7tYIFQi+IlLB2da0ximHDXVo5H +NP78Egfpy9iiFQqaUT8mGXAYqZk3cZixW+R6hELjJ09HwcXJ8TBLf28KfCpAZQ3Aui+ dw9QcehkWSbf5H8hUm63NWsXmLlPDOF5x2z8cGT8XIN6ApoZm0tOA42XW1bo0YN5/Ng+ NFhcF9Q7gIIDxrKo6FQkcDpuMkTZEmhT70kdOUNFGM9brEa6Y9HGfSWyICU4uBH77oh5 Dvea4YRuPaUUsXj7+gR2y2yhV5R2R4xQyxoRNtGXuocOSWBquqUT4kOIN2RE7KjathAh c+dQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=taUicS8R; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=1gFlIHwq; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-145388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145388-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id mc6-20020a1709032b0600b001e58bb476bdsi6892411plb.532.2024.04.15.08.01.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 08:01:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=taUicS8R; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=1gFlIHwq; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-145388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145388-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 79D1D285861 for ; Mon, 15 Apr 2024 14:52:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87AFA73199; Mon, 15 Apr 2024 14:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="taUicS8R"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="sV44x0e5"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="1gFlIHwq"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="bX6lMNi2" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D9A1E52A for ; Mon, 15 Apr 2024 14:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192726; cv=none; b=AgSJqi5Lo1GKVXp+3mTfjtoyCGY6WQU3ZyvH6wls4QwhtJSum5N255aC9uZlOpW/wbL7CgMxwMdk3RBI17Hq2E98jx4w/fYTBxRR2YTItMvRsyMdUMhLDAuRtnV9UeKucI9mQe0QUHB75urakCWF6QkpjsMIrVQQuV7Y13cBppk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192726; c=relaxed/simple; bh=q5/Vyrh3BH8QrwI/ldHZZi/erkC4kRjXGlONfzX1smc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TloCOolSIiQpVIvPQ+lIQDCiauTratqsKAbcD5/ESEGtRY2NjZLRbCaFk+HQ9VVU0b1jaeLWXjvmO9e/QWHBbCvdecqHO89RB5iWEDF2XRyXxTRPZb4A250MSt2wnH3Nw9J8dKTJAdCz2XucUhl7WNPdpf9yhi3Of9lno6cnoMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=taUicS8R; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=sV44x0e5; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=1gFlIHwq; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=bX6lMNi2; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E100D37225; Mon, 15 Apr 2024 14:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713192722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=taUicS8RUcAKBhngMZLBJcmqPKmS/fcT7+4cggVszAuGFd9l9e1Y2Cx1aal6ZYF5HCvpgV b/8FsdWdN3J6OZ4cTVP4e6TeqiHcR64xFVDUEswTDx2bSt8yJf5o7wYkz2Gy8GoAWOD+28 DxXfeZFLxxZQwgDmjmyZiUTtZzYnFbw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713192722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=sV44x0e5u58amHmHzsHC3h82mL3J/I7vUtTEQWW+0XgU6Etnp0gcjqx4gwQVkeL9YD1pCz sVfExs3I/iSB7ZAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713192721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=1gFlIHwqEkMuO50/VrCH39v5SJI+HO5hp7IWMwSAVwNEQ6TfaOBiv4RaHEv3CNt9JIbXK2 bWLC3qRyQbC/rlBOJF5reiB4G6VpJyrIncHQk3HiaN49CM6peWMhUSOF4OSaUUT1DD86Zz 6w95XIePpy40daz4EtH84yhwmPYTGlU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713192721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=bX6lMNi2M24RlR7OIxzGfE9V6qGHZ18j7ona/BlW0gtfRwiJEX+9/1EP90rAyxGl2MsUKY k/DJYKwLESdYgaBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C7C351386E; Mon, 15 Apr 2024 14:52:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id L+lWMBE/HWZQMQAAD6G6ig (envelope-from ); Mon, 15 Apr 2024 14:52:01 +0000 Message-ID: <652e9d20-07a9-44e6-abb6-c644f5f3e996@suse.cz> Date: Mon, 15 Apr 2024 16:52:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slub: Set __GFP_COMP in kmem_cache by default Content-Language: en-US To: Haifeng Xu , cl@linux.com, willy@infradead.org Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240413155603.617554-1-haifeng.xu@shopee.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240413155603.617554-1-haifeng.xu@shopee.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Flag: NO X-Spam-Score: 0.20 X-Spam-Level: X-Spamd-Result: default: False [0.20 / 50.00]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.01)[49.41%]; XM_UA_NO_VERSION(0.01)[]; RCVD_TLS_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,google.com,lge.com,linux-foundation.org,linux.dev,gmail.com,kvack.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] On 4/13/24 5:56 PM, Haifeng Xu wrote: > Now the __GFP_COMP is set only if the higher-order is not 0. However, > __GFP_COMP flag can be set unconditionally because compound page can > not be created in the order-0 case. And this can also simplify the code > a bit (no need to check the order is 0 or not). > > Signed-off-by: Haifeng Xu > Reviewed-by: Matthew Wilcox (Oracle) Thanks, added to slab/for-next > --- > mm/slub.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index e7bf1a1a31a8..49a3ebefab86 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s) > if ((int)order < 0) > return 0; > > - s->allocflags = 0; > - if (order) > - s->allocflags |= __GFP_COMP; > + s->allocflags = __GFP_COMP; > > if (s->flags & SLAB_CACHE_DMA) > s->allocflags |= GFP_DMA;