Received-SPF: pass (google.com: domain of linux-kernel+bounces-145468-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 15 Apr 2024 11:34:26 -0400
From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado <nfraprado@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Mike Looijmans <mike.looijmans@topic.nl>, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] power: supply: ltc3350-charger: Add driver
Message-ID: <141c40a7-9c15-4d58-9081-073c5c72606b@notapiano>
References: <20240409135442.37732-1-mike.looijmans@topic.nl>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.dab85cfc-973d-4930-8fea-324aa26b5801@emailsignatures365.codetwo.com>
 <20240409135442.37732-2-mike.looijmans@topic.nl>
 <5hpl2kspf667hmmxgg36ahiux5rs364qzrg2itpljspspa47vp@dsbnhdnq5s54>
 <efae4037-c22a-40be-8ba9-7c1c12ece042@topic.nl>
 <lxxwadaf2mrghy2kygm3cucb7ygl5qu4dxnmpbancrm2hwjm4g@5eudactyudca>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <lxxwadaf2mrghy2kygm3cucb7ygl5qu4dxnmpbancrm2hwjm4g@5eudactyudca>

On Sun, Apr 14, 2024 at 07:29:56PM +0200, Sebastian Reichel wrote:
> [+cc Nicolas]
> 
> Hello Mike,
> 
> On Fri, Apr 12, 2024 at 08:53:58AM +0200, Mike Looijmans wrote:
> > > please share output of
> > > ./tools/testing/selftests/power_supply/test_power_supply_properties.sh
> > > below the fold with your next submission. It's useful for verifying,
> > > that you got the unit scaling correct for the standard properties :)
> > 
> > Will do. Did a quick run on the driver as it is now, that yields the
> > following output:
> > 
> > (Any thoughts on the "arithmetic syntax error" messages?)
> 
> The script contains some bash specific shell extensions and should
> use /bin/bash instead of /bin/sh in the shebang. Just call it with
> /bin/bash ./tools/testing/... and you should get rid of them :)
> 
> Nicolas, do you want to send a fix for that to Shuah with Reported-by
> from Mike?

It was easy to make it POSIX-compliant, so I sent a series doing that instead:

https://lore.kernel.org/all/20240415-supply-selftest-posix-sh-v1-0-328f008d698d@collabora.com

Thanks,
N?colas