Received-SPF: pass (google.com: domain of linux-kernel+bounces-145471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Apr 2024 17:34:59 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Raag Jadav <raag.jadav@intel.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, 
	andriy.shevchenko@linux.intel.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pwm: dwc: allow suspend/resume for 16 channels
Message-ID: <3xyvaqfbm3wud675co3pbli2ha7doalhoazcjnwnewqi6muqn5@4xj6sjrlpfr4>
References: <20240415074051.14681-1-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jhv2bnx5kb2cgyz2"
Content-Disposition: inline
In-Reply-To: <20240415074051.14681-1-raag.jadav@intel.com>


--jhv2bnx5kb2cgyz2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Apr 15, 2024 at 01:10:51PM +0530, Raag Jadav wrote:
> With 16 channel pwm support, we're registering two instances of pwm_chip
> with 8 channels each. We need to update PM functions to use both instances
> of pwm_chip during power state transitions.
>=20
> Introduce struct dwc_pwm_drvdata and use it as driver_data, which will
> maintain both instances of pwm_chip along with dwc_pwm_info and allow us
> to use them inside suspend/resume handles.
>=20
> Fixes: ebf2c89eb95e ("pwm: dwc: Add 16 channel support for Intel Elkhart =
Lake")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> Changes since v1:
> - Drop error message for -ENOMEM
> - s/data/ddata/

Thanks for addressing these concerns. I applied this patch to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-=
next
now.

I consider sending this to Linus before v6.9, but I'd let it cook in
next a few days before doing so.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jhv2bnx5kb2cgyz2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYdSSIACgkQj4D7WH0S
/k5voQf/S6JRIzY0Isn0KWRXQC4582LSqdS5RQqbHvtW+4zIRaIwOuysE1bNGVcV
hmWb9H8HtsqXnmYIMwxvdgYbdEs2oTj4l8JchfbH2OKTQfRCXG1NYMahHM4+ieQX
vdlIO5tDusi/xHaByrpMtGmvDJOQnv0EDcLlKcYT1S98q74pmzembkirn2pjKyrN
2kLfx44GwDWRkIeWV2xD1gzmE71vW9/Ag2ii0EhN9NM5fahaEL3boin2Q5NkJ87E
JeHES3p1KVs1liOXKmqr2YZs0DkKQ9ZLgnc1fDVaujJT919xExOxW92X+N0vtm6R
qpbB/QdwJa3+1x9Wm4wtHPqgVj8isw==
=yDR7
-----END PGP SIGNATURE-----

--jhv2bnx5kb2cgyz2--