Received-SPF: pass (google.com: domain of linux-kernel+bounces-145550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <03f357e6c16d13924b705513446e4eac37e38a99.camel@perches.com>
Subject: Re: [PATCH] PCI/AER: Print error message as per the TODO
From: Joe Perches <joe@perches.com>
To: Abhinav Jain <jain.abhinav177@gmail.com>, mahesh@linux.ibm.com, 
	oohall@gmail.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, 
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
Date: Mon, 15 Apr 2024 09:19:59 -0700
In-Reply-To: <20240415161055.8316-1-jain.abhinav177@gmail.com>
References: <20240415161055.8316-1-jain.abhinav177@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-04-15 at 16:10 +0000, Abhinav Jain wrote:
> Add a pr_err() to print the add device error in find_device_iter()
[]
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
[]
> @@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void=
 *data)
>  		/* List this device */
>  		if (add_error_device(e_info, dev)) {
>  			/* We cannot handle more... Stop iteration */
> -			/* TODO: Should print error message here? */
> +			pr_err("find_device_iter: Cannot handle more devices.
> +					Stopping iteration");

You are adding unnecessary whitespace after the period.
String concatenation keeps _all_ the whitespace.

The format is fine on a single line too.

Something like:

		pr_notice("%s: Cannot handle more devices - iteration stopped\n",
			  __func__);