Received-SPF: pass (google.com: domain of linux-kernel+bounces-145549-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 15 Apr 2024 17:28:22 +0100
From: Conor Dooley <conor@kernel.org>
To: Herman van Hazendonk <github.com@herrie.org>
Cc: sre@kernel.org, benwolsieffer@gmail.com, chris.chapuis@gmail.com,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: max8903: specify
 flt-gpios as input
Message-ID: <20240415-pretty-recite-127842ed9a10@spud>
References: <20240415151645.1986014-1-github.com@herrie.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="JCzRbrKQeuOfJEof"
Content-Disposition: inline
In-Reply-To: <20240415151645.1986014-1-github.com@herrie.org>


--JCzRbrKQeuOfJEof
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote:
> The FLT pin was incorrected documented as an output. The MAX8903 uses it =
to
> signal to the processor that a charging fault has occurred.

I guess this is just a matter of framing? Input to the hardware running
the OS but an output from the max8903?

I'm okay with whatever wording causing less confusion, which may mean
something that specifics what this is relative to?

>=20
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>

The SoB email should match the from email fyi.
Cheers,
Conor.

> ---
>  .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903=
=2Eyaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> index a8d625f285f1..86af38378999 100644
> --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> @@ -34,7 +34,7 @@ properties:
> =20
>    flt-gpios:
>      maxItems: 1
> -    description: Fault pin (active low, output)
> +    description: Fault pin (active low, input)
> =20
>    dcm-gpios:
>      maxItems: 1

--JCzRbrKQeuOfJEof
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZh1VpgAKCRB4tDGHoIJi
0jw/AQDaumli7edYvHrMoE4DDwEVzCH7wtuaBqIpvwcPYZM7xQEApHEIX3B9VcZx
5Gw1n8eCthaQuGt/yznp5f+vfVxRUAg=
=1mQ7
-----END PGP SIGNATURE-----

--JCzRbrKQeuOfJEof--