Received-SPF: pass (google.com: domain of linux-kernel+bounces-145539-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 15 Apr 2024 09:20:29 -0700 (PDT)
From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Jianfeng Wang <jianfeng.w.wang@oracle.com>
cc: Vlastimil Babka <vbabka@suse.cz>, 
    "linux-mm@kvack.org" <linux-mm@kvack.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    "penberg@kernel.org" <penberg@kernel.org>, 
    "rientjes@google.com" <rientjes@google.com>, 
    "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>, 
    "akpm@linux-foundation.org" <akpm@linux-foundation.org>, 
    Junxiao Bi <junxiao.bi@oracle.com>
Subject: Re: [PATCH] slub: limit number of slabs to scan in count_partial()
In-Reply-To: <5552D041-8549-4E76-B3EC-03C76C117077@oracle.com>
Message-ID: <bb1d4c3e-0c1a-0868-5c1f-9a1de8692db1@linux.com>
References: <20240411164023.99368-1-jianfeng.w.wang@oracle.com> <e0222219-eb2d-5e1e-81e1-548eeb5f73e0@linux.com> <38ef26aa-169b-48ad-81ad-8378e7a38f25@suse.cz> <a8e208fb-7842-4bca-9d2d-3aae21da030c@oracle.com> <1207c5d7-8bb7-4574-b811-0cd5f7eaf33d@suse.cz>
 <e348dfcd-6944-4500-bf84-c58b8c2e657f@oracle.com> <5552D041-8549-4E76-B3EC-03C76C117077@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-810623552-1713198029=:146654"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-810623552-1713198029=:146654
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Sat, 13 Apr 2024, Jianfeng Wang wrote:

>>>>>> kmem_cache_shrink() will explicitly sort the partial lists to put the
>>>>>> partial pages in that order.
>>>>>>
>
> Realized that I’d do "echo 1 > /sys/kernel/slab/dentry/shrink” to sort the list explicitly.
> After that, the numbers become:
> N = 10000 -> diff = 7.1 %
> N = 20000 -> diff = 5.7 %
> N = 25000 -> diff = 5.4 %
> So, expecting ~5-7% difference after shrinking.

That still looks ok to me.

--8323329-810623552-1713198029=:146654--