Received-SPF: pass (google.com: domain of linux-kernel+bounces-145587-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: ArcticLampyrid <ArcticLampyrid@outlook.com>
To: sbinding@opensource.cirrus.com
Cc: ArcticLampyrid@outlook.com,
	david.rhodes@cirrus.com,
	james.schulman@cirrus.com,
	linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com,
	rf@opensource.cirrus.com,
	stable@vger.kernel.org
Subject: Re: Re: [PATCH] ALSA: hda/realtek: Fix internal speakers for Legion Y9000X 2022 IAH7
Date: Tue, 16 Apr 2024 00:49:41 +0800
Message-ID:
 <TYCP286MB25356BFBD3D67D4E1FD09732C4092@TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <335eb6d4-424e-43e5-8990-3d87ad579e7c@opensource.cirrus.com>
References: <335eb6d4-424e-43e5-8990-3d87ad579e7c@opensource.cirrus.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYCP286MB2535:EE_|OSOP286MB3906:EE_
X-MS-Office365-Filtering-Correlation-Id: cfc8a9c9-86ed-4b81-41eb-08dc5d6c215c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cNE9zPy3aMjas//GQm7rgGr0WfEORC8dN/6FZJlwyVtBnkAI2W3xzwyz7lEGa/vWBBW82fxTLp6OZFLQ3gr8OikfryFsOkC+elM2uZmfM0IsH/AYfLDvdTc73mF4yPNC85J4Eo9fBSsvJEDQMfmknYVLc45+x6/U30RCNoip4RQtUNOJm5WrxFlLnIW2G6mtdKBXMZEn9vQIjrbh4Q1tM73dOBCb4x1a3cfBHep/76mvg3WVARR5aImu6YKBlK+pU08Jikd8IqBQLK6rA/nzmLPIlrxI+DN3eoMdItzzZRC0H51/7NFhG1x67V6IoLk5ESHKYJJBQjX0DwOIVeyMLDpGNKEHnFkO/86CfHdhHZ0pdqKaU967OzRUVwmgVT1iCyrUL/4lE2yZa+EFoJDPg5CT4flwT8w2JRSiMoBNvHGi+iR12IAAhDClh0N5zrMeSw8npUZ/fSSoL9LwKAxn6Gi5RpOf7kGisy+DxqJ1oPxeiYf3ws9DdN69uxeIfNWZDKfc7Q5s3OZ1mYT9qJgUTB47uWi2y5c7/eG8ez2BWvfntwRo2bneMNeNWCvR1ndFbPXvqO7rhT16VT5ZHzUgEOfNE0vAjlKj0/yuua+NZOLVcL645qn5tJ1anCdeJOCM
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cATY71u9wXt/znaETbL0UDKvWqQrxumO+a896XpjbP+1y0oJWcwKneymWLez?=
 =?us-ascii?Q?Rsn+4i5PkORrwevLH4+svDwkBBWshTqtDF4/X06enUGo/hgXLRbmgbuvv6es?=
 =?us-ascii?Q?pJegqNVwn146AADws1V17BkOJCBVamunQ+xVHZNMpckr4BaHclrutT11Kpbj?=
 =?us-ascii?Q?UKDgSJoVMyzttXUC717qVLCGxBqG43G/R4zSxJz7j8x6QjfFyNAuODMyQzzB?=
 =?us-ascii?Q?XcCP5DuOfcf8B51wBZqBS3oQsTpk9YES0vme5iyNSAQCdIvvi5KnyvaD0L0V?=
 =?us-ascii?Q?mQAHvpE54Rz7GPriw/KFHGu/6UoKx8WoELbAdMN411oMVKRbPh0K3MBe/irh?=
 =?us-ascii?Q?8UuK8T2ATjRysXtjYKCstD/tmS3FySItRXGCSs03hUau9PHaT1kDcKj4gTNe?=
 =?us-ascii?Q?bXISW/t2acmLfpdlJGsPM3rW8APHbVkx924jYFsfGL1f/PcCWOblVXu9Bk+z?=
 =?us-ascii?Q?9TV7BhGi967BrqdDF/uOewj+RymL+qU0r5kfeflocZY2FSJhCq9PLmObN1HU?=
 =?us-ascii?Q?kAjiiiUANp9DoK0lZXfgCz8UXtoUjpcbZrKaDdUSreNk3p5+XGdqlwW1kURe?=
 =?us-ascii?Q?wtcqVrcLqnvAQUjXAXdR+5p5dB0AyCweZ1tm9xWTSsfjS03as7PlkQ9oOFoP?=
 =?us-ascii?Q?jaoH/OSyM7mbSWYcYZbTBIrBuQkYhTN7O/OYd3+tB5Fax3ZOC+ysfF4try0+?=
 =?us-ascii?Q?V5NKjvuk/DFsRDp1/ybLtHXLMOEa/reZX8tm1QUVjlVRI0x/2geXA0A19pJp?=
 =?us-ascii?Q?rIB8I1yaSF49+u2uLc+dkushlCaq3GsR7piYSPYc67Minkz7zPPehFRxm6j3?=
 =?us-ascii?Q?1ZLpzLMzv/0JH5BS32UTvGYGGGoXKk+rD0Mjcn+R+Li6LVikIIPw4ECwlWLF?=
 =?us-ascii?Q?oAgMoZktOPCPeKVF0Aqz7U6CMl9qttlRE/MVdYC1VLyLRe7UJ4C2Uu5Q9ax5?=
 =?us-ascii?Q?J1UJTRfe/+Nd8mE4CTXwzmGNGK7GvS2INK5276ZndTzvSYY9dFspZiXRjZU9?=
 =?us-ascii?Q?ccykhlJEFQBt5kt6wHj+EW3caSYLcLyQsHBoc25bRyqDPTH0Lg3H75hfgbjo?=
 =?us-ascii?Q?ydUP+afiHIAVMbpHWnPDYA5Jswroz1QCiEXn2M2/RbgmPwC1jKmYmvHRRJxH?=
 =?us-ascii?Q?enVWnLh0GTaihgd/sFwoImmcf9K24j6FbGUmvYEWYfld0vmQtlNqC53LagHC?=
 =?us-ascii?Q?7BRXVf8gIMr9TTf/F+EvlM6IXyMyjgfbFURyMr5yE6gFz0k5W9Syh45YoxQK?=
 =?us-ascii?Q?/rj10bvW1uC7j1nUp+07j/+0VJ230B2x6tah0wyyi+orRBiVkKVGVWMA8Brj?=
 =?us-ascii?Q?HIM=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfc8a9c9-86ed-4b81-41eb-08dc5d6c215c
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 16:50:18.0710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSOP286MB3906

> According to the ACPI that I have access to, this is not correct - the
> Speaker ID is on index 2 not index 1.
> Index 1 has a reference to the interrupt line. Therefore this should be:
>
> 	{ "17AA386E", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },

Sorry, but I'm unable to retrieve the speaker ID index from my BIOS.
Please tell me how to check it, thanks.

I've tried using `spkid_gpio_index = 2`, but haven't noticed any changes.

> The reason for any issue you see may be
> because you have assigned the speaker id for the interrupt gpio in ACPI
> as mentioned above.

Despite changing `spkid_gpio_index` to 2, it hasn't worked with `generic_dsd_config`.

The journal logs show:
```log
kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 I2C devices.
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Adding DSD properties for 17AA386E
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Using extra _DSD properties, bypassing _DSD in ACPI
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Cirrus Logic CS35L41 (35a40), Revision: B2
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Adding DSD properties for 17AA386E
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Using extra _DSD properties, bypassing _DSD in ACPI
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Reset line busy, assuming shared reset
kernel: genirq: Flags mismatch irq 58. 00002088 (cs35l41 IRQ1 Controller) vs. 00002088 (cs35l41 IRQ1 Controller)
kernel:  cs35l41_hda_probe+0x94b/0x9d0 [snd_hda_scodec_cs35l41 5706d5af6d4d4abb9d294b49d5cd4cc8a51aad9d]
kernel:  ? __pfx_cs35l41_i2c_driver_init+0x10/0x10 [snd_hda_scodec_cs35l41_i2c 8858b01ad506c8ac36ad9a656c7cb71d39d6ec09]
kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Failed to request IRQ 58 for cs35l41 IRQ1 Controller: -16
kernel: cs35l41-hda: probe of i2c-CSC3551:00-cs35l41-hda.1 failed with error -16
```

I believe this error might be caused by the configuration of the same IRQ multiple times.

Additionally, I checked the Cirrus SmartAMP driver on Windows, which appears to use only one IRQ (ID 58) on my device.
Therefore, I don't believe there is a need to configure two IRQs on my device.

The message `Flags mismatch 00002088 vs. 00002088` is confusing.
Further investigation reveals that the following check in `__setup_irq` failed:
```c
if (irqd_trigger_type_was_set(&desc->irq_data)) {
    oldtype = irqd_get_trigger_type(&desc->irq_data);
} else {
    oldtype = new->flags & IRQF_TRIGGER_MASK;
    irqd_set_trigger_type(&desc->irq_data, oldtype);
}

if (!((old->flags & new->flags) & IRQF_SHARED) ||
    (oldtype != (new->flags & IRQF_TRIGGER_MASK)))
    goto mismatch;
```

While the previous request used flags `0x00002088 = IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_LOW`,
the `oldtype` was actually `IRQF_TRIGGER_RISING` (0x1) rather than `IRQF_TRIGGER_LOW` (0x8), leading to the mismatch.

I am new to Linux Kernel, not sure if this is expected behavior or a bug for `IRQF_SHARED`.
Ideally, a clearer message may be provided to facilitate understanding.

Sorry to bother you if I make some foolish mistakes.