Received-SPF: pass (google.com: domain of linux-kernel+bounces-145646-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <535f3756-80d9-4599-bf73-a8785d18c399@kl.wtf>
Date: Mon, 15 Apr 2024 19:14:33 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to
 power-up transition
To: Johan Hovold <johan@kernel.org>
Cc: lma@chromium.org, benjamin.tissoires@redhat.com, dianders@chromium.org,
 dtor@chromium.org, hdegoede@redhat.com, jikos@kernel.org,
 johan+linaro@kernel.org, kai.heng.feng@canonical.com,
 linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
 mripard@kernel.org, rad@chromium.org
References: <CAE5UKNqufWZfKLAXLcpBYKQpJEVt6jPD4Xtr=Nesh34VkNOETg@mail.gmail.com>
 <81e1b870-37f9-4ef2-9a3d-87015f32546b@kl.wtf>
 <Zh0qKeI-YPDE-NVT@hovoldconsulting.com>
Content-Language: en-US
From: Kenny Levinsen <kl@kl.wtf>
In-Reply-To: <Zh0qKeI-YPDE-NVT@hovoldconsulting.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/15/24 3:22 PM, Johan Hovold wrote:
> We also use it for devices that may not be populated (e.g. an optional
> touchscreen) and in that case we should not print anything.

I sent a patch series[0] that shows how the same can be achieved 
(gracefully handling missing device + retry to wake device) without any 
smbus probes, following the existing retry style in i2c_hid_set_power().

Radoslaw and Lukasz, it somehow felt rude to tag and blame you for code 
you hadn't seen yet. If my patch ends up favored we should make sure to 
have the appropriate attribution tags added...

[0]: https://lore.kernel.org/all/20240415170517.18780-1-kl@kl.wtf/