From: Andries.Brouwer@cwi.nl
Date: Fri, 4 Jan 2002 15:16:32 GMT
Message-Id: <UTC200201041516.PAA224847.aeb@cwi.nl>
To: adilger@turbolabs.com, phillips@bonn-fries.net
Subject: Re: [CFT] [JANITORIAL] Unbork fs.h
Cc: acme@conectiva.com.br, ion@cs.columbia.edu, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org


    grep -r "sizeof (" linux | wc -l,
    grep -r "sizeof(" linux | wc -l:

    sizeof (foo): 1611, sizeof(foo): 19364 => -bs should be removed

    > > -psl: Put the type of a procedure on the line before its name.

    grep -r -B2 "^{" linux | grep "^[^ ]*(" | wc -l,
    grep -r -B2 "^{" linux | grep "^.* .*(" | wc -l:

    int
    foo(int x): 11408, int foo(int x): 57275 => -psl should be removed

I do not think good style is best defined by majority vote.

    grep -r "\*) [a-z_(]" . | wc -l,
    grep -r "\*)[a-z_(]" . | wc -l:

    (void *) foo: 11274, (void *)foo: 17062 => -ncs should be added

    > Not putting a space after a cast is gross ;)

    Well, it seems you are in the (slight) minority on this one.  It's not as
    big a margin as the other ones, but still measurable.  I wasn't able to
    find any examples from the King Penguin himself on this one.

Read old kernel sources.

        de = (struct minix_dir_entry *) (offset + bh->b_data);

	:"S" ((long) name),"D" ((long) buffer),"c" (len)

	if (32 != sizeof (struct minix_inode))


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/