Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1591569lqp; Mon, 15 Apr 2024 10:43:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX2q1lYAFFbFogGp9K2H1DEpi3Fd5OJfvAD+GBWhgq30qNg2oRMiuFju0XWJ2EYdaV1dXZ1i6zi4LiMq2XP+eXiSG1ejHRFAODwRISWaw== X-Google-Smtp-Source: AGHT+IFYrLFBgoUnYg5lw9ZPXy+Iu/grjBnbihttfgw/U1gTXRAk5or9nCmr890ILDcR94SFs+ld X-Received: by 2002:a17:907:930d:b0:a52:36fd:679 with SMTP id bu13-20020a170907930d00b00a5236fd0679mr8657579ejc.4.1713202981288; Mon, 15 Apr 2024 10:43:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713202981; cv=pass; d=google.com; s=arc-20160816; b=JGrftd0ggKLoZ4Ym83c/v3SLqCqQB5smjR6elWaxlebvgwgqUz/aXAn4OxOh75kROu +mp2wA5twbPBf0A/Q/28TyU23WyRVuYgmfHIsnbiYi6mM8jSlKr1MXo0EABSPNMSYZ28 OMhhzFrn96VQ5knNHgWYxwRoLgoi6JYlgmza1wSYMDAK/8Lbo5iQ6282aovavep3qtd2 EnZCqITRE3WOqDAbHEBBJvJIx9+hKIJvHJvuDK3TqmQCrDvMcHdxU5Dqzukps5oqnQuX b8XKaE8N0klZMYSv2dS8/EfAWD+Aarg9e8Iysu8hyGrxWblkrxJKN2VUE5j+ktgvIcjX OQVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=qQrAeU4gmZ2S8vNVTdbnNXQFV9PtjRJsc3VQpaRmqLM=; fh=p0MNRxzaThiP65O8rWJHyFT9Up6tc6CsB2HMHpJvPA0=; b=FzmzmZU9a8A32JRygqKpQbvbJPw5rWxFsgULvC55x4gtBk5rOFGCSxfOL5ggUmdNVw 9VGqFT31O9RxsOnsOVi2IjkTfVOntDBD17FG0oQQ8Vq0peXGFewXBsBra/hIvKbOW0JR zh5po2RaWTJ7boVv3ylzCnh/YRkEHcDtpYCb14i/13KlLV5Vw7vaBnctIcDvDx342wBN g8rQzKe7PQxoDv4FLgXK0skJBWaeBKF2lippAN01F/eldG/DnHsnf1Kf0IFu5Ufq8n6k Pp1r0K0K2JCkOeirf22WpVp4lgeEsnivEJmXNdniId/zOp2CMpjnUeU4V3okbHIsQ9Yr lFiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=joHMUDe3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ss12-20020a170907038c00b00a526b07eecdsi1062894ejb.16.2024.04.15.10.43.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 10:43:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=joHMUDe3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ABF1B1F22A87 for ; Mon, 15 Apr 2024 17:43:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D26AA12AAD4; Mon, 15 Apr 2024 17:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="joHMUDe3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A5682487 for ; Mon, 15 Apr 2024 17:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713202973; cv=none; b=X+4Z4D28L5MLeYwyE7TRw1YmnYs4H0r0uGp3lJVd8nEffkpSdLJ39HF/e9QeEjsOGsbNQXaT1O2XT8qR3opZhNTtEAaqHK23p848GznjE6MO/+GsnENei2irxyrcUqZyRmV+SdT7SGLY+77LDTXFwCSbsxXI0fnb/m3YYiWhmpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713202973; c=relaxed/simple; bh=b5rLA/xVoC+OnWb0hZtV4A0foD6WE7RauuxZaOV01Mg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JEjWSbgBoADLc88rKfIEYw7xg3ljxwixB9GfHWLC1yxK9TgSX/1u//S4REjXg/nOb7tVBJVU1ZqxIR9AcLBPhLTHn+lvxpa5JwukP9Xxmpr7Cs4eXWCxFmXuHmqorbUdxLHRb1WVJlZTKfcv9V5dztAWntkztb1PFmyFfK9QdjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=joHMUDe3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF3DC113CC; Mon, 15 Apr 2024 17:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713202972; bh=b5rLA/xVoC+OnWb0hZtV4A0foD6WE7RauuxZaOV01Mg=; h=From:To:Cc:Subject:Date:From; b=joHMUDe3XpppSRRtQPD1MK47Dqe0DuaSAuEkdvdS+QkgldwdLCa7GWZDYld4zOc/Y C2f+RzkS/7WbglclkVG8xy+L7ipbFF9aMiA5h7WFmvr4DGgd6Z4B+jQ32DdZyikgne Vs6x6Vv1rmX/e+kuXHXsbzubN7QbEGyiFshsw+itXPA3YlTpgV1eWUjEZ8e6RHzebY 8FRyTXPj59ZpchT5O80bda4/9uuW48nKKb8JWauEYZ563mYJdrhlXRoM78OCTxh+gD BAGbhjrJBcLe9ggXi9ci+h81/p35HDlrP91bBncIFPxWWpfsVvVSbvLY/kIsCp34KJ /rdxZyjpKbD+Q== From: Arnd Bergmann To: Vinod Koul , Kishon Vijay Abraham I Cc: Arnd Bergmann , Heiko Stuebner , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Mon, 15 Apr 2024 19:42:25 +0200 Message-Id: <20240415174241.77982-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The newly added driver causes a warning about missing dependencies by selecting CONFIG_TYPEC unconditionally: WARNING: unmet direct dependencies detected for TYPEC Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] WARNING: unmet direct dependencies detected for USB_COMMON Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] Since that is a user-visible option, it should not really be selected in the first place. Replace the 'select' with a 'depends on' as we have for similar drivers. Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") Signed-off-by: Arnd Bergmann --- drivers/phy/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index a752ccdddb86..08b0f4345760 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_USBDP tristate "Rockchip USBDP COMBO PHY Driver" depends on ARCH_ROCKCHIP && OF + depends on TYPEC select GENERIC_PHY - select TYPEC help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588. -- 2.39.2