Received-SPF: pass (google.com: domain of linux-kernel+bounces-145687-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <fe8e56bb-55bf-4130-876f-3047da182da1@intel.com>
Date: Mon, 15 Apr 2024 11:03:05 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate
 header
To: Dave Martin <Dave.Martin@arm.com>
CC: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-9-james.morse@arm.com>
 <0ba51259-cb7a-463e-aabd-f88bd0c4007b@intel.com>
 <ZhlegNN3zZ4Q1lk6@e133380.arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZhlegNN3zZ4Q1lk6@e133380.arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnRNbFBoZDdkNWhBa05KMTlYZ3lPRTJIMU1xR0l6NWFlNm1BYmJFbldxOFB1?=
 =?utf-8?B?ellwRlBPSzlGUm5nb3VkZnMxTW1IUUh3eGJZbmRUTW1JcVJNUTZTeGdIYkdp?=
 =?utf-8?B?b3I5cHhJSjRnQS9lNDBPeU1Wb2pQZnB5engrazdCcVcrZFVZQUVZUFY1dEhV?=
 =?utf-8?B?emswa1pKdmNqZEN4Q1UvamVMV2VpZUhCOGNMNDIzSU5xemVXSUdZdEVYUWhO?=
 =?utf-8?B?TDRQR25SN1ZmeDdYc0NhZlBRQTRZdHFncVhSSFplSHlON01ETmt2QlpzM3lM?=
 =?utf-8?B?RUUya2NvUFg2dXFsLzB6M2tERnczQVY0RTJTTmxUY2ZlWUQ3amNESExCOERn?=
 =?utf-8?B?SFd4eUx1TjE1eUZMVmpwZndjZ09iZHFZV0I3WWptNmZQVlNaRUo4d244V1JP?=
 =?utf-8?B?VnN2WGNXeVhJSi9oVVBvTEZNTDZQUkQweUNSWjNPL3h1eWRsRFptUnFKdlJG?=
 =?utf-8?B?STVQQjU0bWhpZU9YNTBsOS8vYUw5UDh0bXBySGdMMFBFT0xrSFd0ZEF2dkMz?=
 =?utf-8?B?d1pnaUdJMmpuMmcrc0ZOTnVGTXlvZHQvVXBJTjRzb0J4NjlBenc3RHNnbCsx?=
 =?utf-8?B?Y3lpVzZ6UnpxcXp0ajRWOW9Nd1huWnNXYklxWThxaFNyV1RndW9vdUEyUVpv?=
 =?utf-8?B?YjV6YS9tK2Y5R3VZMkdnb0g1c1I3VndzY3UxUVdYZ29vblpQWUlnWDNUZ25Y?=
 =?utf-8?B?c2xkdVBUSjBLR3k2VEtYaFFzaFpzd0ZmbWNWWDZxelA3aHhxdlhnVWM4M3R3?=
 =?utf-8?B?M3hhNkZTdlVkNGZBZ1VSeTBDYXRKSWF1M0F4SFZlSUpqTmN0azdYV2R2elky?=
 =?utf-8?B?S0xtT1dpUHpyTE9iUFVqa2Q0UkM5cktMMWgxU1BoZDFFYzNVKzBHcXQ5U0dC?=
 =?utf-8?B?M2k5NmpPd1IxL1NnWldnaGMvaWNJbWRNSDNhSlNKczEwSGNYZUtDV05aT0xE?=
 =?utf-8?B?eER2NFd1c2VUZ0V1ZUVoMVVja2pVekdNcUd3ZzR0UXNFRExnRUU3L2llSVQr?=
 =?utf-8?B?YnkveHJCcVF0UXBvdGFHdnY3RUZFL3I5SFEzaHMxNWdmT056SDN4K0l2Yyth?=
 =?utf-8?B?cDI5dC9lTWZuMWh6TERBajI2SGJ3WnZQQldHVzJ6QlZLNHZGM2ZTemtqUFVz?=
 =?utf-8?B?V040eDNNbVZiL2txcTliQk5hc1dxV1cyZDRmTkNXMENqUHh0czZsYVBWV0Ir?=
 =?utf-8?B?YWRNOTYwUDNtVWRLSGtvWmdxMVczMEFlOTkvZzkyV204K0NKU092ZGRxVkxY?=
 =?utf-8?B?eGF0aWJQYU1LRWYrN0tUcHZ6VFMyc3I3RjduNVNMejBZWExCRjdZYWZYT0pM?=
 =?utf-8?B?VURMYTRyVFBMRktDWW1tZGNjZ3Y2L1FYUXh5ZnhNRkdHNVNDV0lCaldhMzQy?=
 =?utf-8?B?UjR4SGx2NVo5SEFzcGhBdzV2Uzl6VDFIQit2Mzl0WmU1eUg4TFFYTVg0WS9j?=
 =?utf-8?B?eDRGaUJxSWJWZmVCcE43d1lwVU9YMmpGenFCdnNRcno0NmVHTEtLdGZDSzdT?=
 =?utf-8?B?dG5BMmUvUm0wdGlwaUVic25RaFhGKzcvRjhmaWNpeWpDTHhqRGhNeWhKMmx2?=
 =?utf-8?B?TExZcktaWmxtejJuNjJ5WTBqVnZNSmNpSUVybm9aTFNiYVBSamEzczEwTDNp?=
 =?utf-8?B?T0JMckUrRE9kMmR6UmxCNUcxbU5HTUtoTWVtRitUUlZKMFh5ZmVTdDdyenBx?=
 =?utf-8?B?REdlc1NjaG84bkFtNDUyT0lucFZzdTVIaEQxdTI5ZmFqZllRT2xKSWlwSDBm?=
 =?utf-8?B?NGdGZzFDRmd3TjJQd0JXR3BGWi9Bb245K3FnOHBiNStLcWdRWFRTR0FjR0Ni?=
 =?utf-8?B?eDkrZmlIMmk4dENZSy9MeTZwVHNtd0plRHJRVzFSZ2dZYWVVV2FLQURIeThs?=
 =?utf-8?B?UjZyU2F4RHVkRHNCNGJJaFFoNVRtWnRLbU0vZFBzQXJ2cmxqTGJGdE5MS3BV?=
 =?utf-8?B?Nk1lSmg2TkVxWFVEYzlzOUtmZGIvSklOcDZ1Zmk4VlB2SHRjbDBJTzhzNTF4?=
 =?utf-8?B?WDFvbEMwcEdkNmNwdzg3WUF1dnp0UjlXd3JwZlhqR0FCNHdUODdXTWNDZ29v?=
 =?utf-8?B?OTBOSS9JUThrR0xpbUhhU280Vzl6WGxwMmtjc0tsYkIwZVlHMGlrVTIzRGQ5?=
 =?utf-8?B?SzY0cGEwdGtXalVMVk8zb1g5bEllelduRjZPMG1CdFF6Y0h1c1B5dWpkZC95?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e135b81e-2cb6-4016-70ff-08dc5d764e9b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 18:03:08.7441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YYZS/qrzKiQ6VJFN6N8jWKXOaMSLqqD84UCKPop/u2U0eznridO4ROGCbTjA1PJb9YwW31+MgNAI+fyu4zkTmhWT59P6DX+jM6pYMJR8C1I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4854
X-OriginatorOrg: intel.com

Hi Dave,

On 4/12/2024 9:17 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:18:00PM -0700, Reinette Chatre wrote:
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> To avoid sticky problems in the mpam glue code, move the resctrl
>>> enums into a separate header.
>>
>> Could you please elaborate so that "sticky problems in the mpam glue code" is
>> specific about what problems are avoided?
> 
> Maybe just delete the the sticky clause, and leave:
> 
> 	Move the resctrl enums into a separate header.
> 
> ...since the next paragraph explains the rationale?

In the x86 area changelogs start with a context paragraph to
provide reader with foundation to parse the subsequent problem and
solution statements (that are also expected to be in separate
paragraphs in that order). 

>>> This lets the arch code declare prototypes that use these enums without
>>> creating a loop via asm<->linux resctrl.h The same logic applies to the
>>> monitor-configuration defines, move these too.
>>>
>>> The maintainers entry for these headers was missed when resctrl.h
>>> was created. Add a wildcard entry to match both resctrl.h and
>>> resctrl_types.h.
>>>
>>> Signed-off-by: James Morse <james.morse@arm.com>
>>
>> ..
>>
>>> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
>>> new file mode 100644
>>> index 000000000000..4788bd95dac6
>>> --- /dev/null
>>> +++ b/include/linux/resctrl_types.h
>>> @@ -0,0 +1,68 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +/*
>>> + * Copyright (C) 2024 Arm Ltd.
>>> + * Based on arch/x86/kernel/cpu/resctrl/internal.h
>>> + */
>>
>> Could this header please explain how this file is intended to be used?
>> What is it intended to contain?
>>
>> Reinette
> 
> Maybe something like the following?
> 
>  * Resctrl types and constants needed for inline function definitions in
>  * the arch-specific <asm/resctrl.h> headers.
> 

ok.

Reinette