Received-SPF: pass (google.com: domain of linux-kernel+bounces-145710-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Apr 2024 11:28:02 -0700
From: Vishal Moola <vishal.moola@gmail.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, willy@infradead.org,
	linmiaohe@huawei.com, jane.chu@oracle.com, muchun.song@linux.dev,
	nao.horiguchi@gmail.com, osalvador@suse.de
Subject: Re: [PATCH v2 1/2] mm/hugetlb: convert dissolve_free_huge_pages() to
 folios
Message-ID: <Zh1xslaqduUr4MHF@fedora>
References: <20240412182139.120871-1-sidhartha.kumar@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240412182139.120871-1-sidhartha.kumar@oracle.com>

On Fri, Apr 12, 2024 at 11:21:38AM -0700, Sidhartha Kumar wrote:
> Allows us to rename dissolve_free_huge_pages() to
> dissolve_free_hugetlb_folio(). Convert one caller to pass in a folio
> directly and use page_folio() to convert the caller in mm/memory-failure.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> 
> v1 -> v2:
> 	- Change additional comments which reference hugepages to
> 	  hugetlb folios per Miaohe Lin. 
> 	- introduce patch 2
> 
>  include/linux/hugetlb.h |  4 ++--
>  mm/hugetlb.c            | 17 ++++++++---------
>  mm/memory-failure.c     |  8 ++++----
>  3 files changed, 14 insertions(+), 15 deletions(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 3f3e628802792..f4191b10345d6 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -861,7 +861,7 @@ static inline int hstate_index(struct hstate *h)
>  	return h - hstates;
>  }
>  
> -extern int dissolve_free_huge_page(struct page *page);
> +extern int dissolve_free_hugetlb_folio(struct folio *folio);

You could drop the extern here as we don't need it anymore. Aside from that
LGTM.

Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>