Received-SPF: pass (google.com: domain of linux-kernel+bounces-145729-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Apr 2024 13:46:49 -0500
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: Rob Herring <robh@kernel.org>
To: Jianfeng Liu <liujianfeng1994@gmail.com>
Cc: linux-rockchip@lists.infradead.org, krzk+dt@kernel.org, 
 conor+dt@kernel.org, linux-kernel@vger.kernel.org, 
 devicetree@vger.kernel.org, heiko@sntech.de, sfr@canb.auug.org.au, 
 linux-arm-kernel@lists.infradead.org, weizhao.ouyang@arm.com
In-Reply-To: <20240413032328.784142-1-liujianfeng1994@gmail.com>
References: <20240413032328.784142-1-liujianfeng1994@gmail.com>
Message-Id: <171320634163.4714.8795054686718423617.robh@kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Add ArmSom Sige7 board


On Sat, 13 Apr 2024 11:23:27 +0800, Jianfeng Liu wrote:
> Specification:
>         Rockchip Rk3588 SoC
>         4x ARM Cortex-A76, 4x ARM Cortex-A55
>         8/16/32GB Memory LPDDR4/LPDDR4x
>         Mali G610MP4 GPU
>         2× MIPI-CSI Connector
>         1× MIPI-DSI Connector
>         1x M.2 Key M (PCIe 3.0 4-lanes)
>         2x RTL8125 2.5G Ethernet
>         Onboard AP6275P for WIFI6/BT5
>         32GB/64GB/128GB eMMC
>         MicroSD card slot
>         1x USB2.0, 1x USB3.0 Type-A, 1x US3.0 Type-C
>         1x HDMI Output, 1x type-C DP Output
> 
> Functions work normally:
>         USB2.0 Host
>         USB3.0 Type-A Host (depend on just applied USBDP driver[1])
>         M.2 Key M (PCIe 3.0 4-lanes)
>         2x RTL8125 2.5G Ethernet
>         eMMC
>         MicroSD card
> 
> More information can be obtained from the following website
>         https://docs.armsom.org/armsom-sige7
> 
> [1] https://lore.kernel.org/all/20240408225109.128953-1-sebastian.reichel@collabora.com/
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588-armsom-sige7.dts | 725 ++++++++++++++++++
>  2 files changed, 726 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588-armsom-sige7.dtb' for 20240413032328.784142-1-liujianfeng1994@gmail.com:

arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: pcie@fe150000: 'pinctrl-0' is a dependency of 'pinctrl-names'
	from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: leds: led_rgb_r:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'default-off' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'default-off' does not match '^cpu[0-9]*$'
	'default-off' does not match '^hci[0-9]+-power$'
	'default-off' does not match '^mmc[0-9]+$'
	'default-off' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dtb: leds: led_rgb_r: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#