Received-SPF: pass (google.com: domain of linux-kernel+bounces-145746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d9856482-0693-a97a-4429-b574ffad1349@intel.com>
Date: Mon, 15 Apr 2024 12:05:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2 26/30] dmaengine: idxd: Assign parent for event_source
 device
Content-Language: en-US
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Mark Rutland
	<mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar
	<mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Will Deacon
	<will@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <gregkh@linuxfoundation.org>
CC: <linuxarm@huawei.com>, Shaokun Zhang <zhangshaokun@hisilicon.com>, "Yicong
 Yang" <yangyicong@hisilicon.com>, Jiucheng Xu <jiucheng.xu@amlogic.com>,
	Khuong Dinh <khuong@os.amperecomputing.com>, Atish Patra
	<atishp@atishpatra.org>, Anup Patel <anup@brainfault.org>, Andy Gross
	<agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Frank Li
	<Frank.li@nxp.com>, Shuai Xue <xueshuai@linux.alibaba.com>, Vineet Gupta
	<vgupta@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Dave Jiang
	<dave.jiang@intel.com>, Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
	<linux-fpga@vger.kernel.org>, Suzuki K Poulose <suzuki.poulose@arm.com>,
	Liang Kan <kan.liang@linux.intel.com>
References: <20240412161057.14099-1-Jonathan.Cameron@huawei.com>
 <20240412161057.14099-27-Jonathan.Cameron@huawei.com>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20240412161057.14099-27-Jonathan.Cameron@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TisrLzBLM2UyTWpIbTE4b0pCMUc1eCtxdlRxK01LNnBDZ2RIbGJUdjFFQjZS?=
 =?utf-8?B?Qll5VnNaQW1GZmVHMVlBTXFVMFJhaXNhbnU2K3VyemRLVzNXaFNabVB3aWRx?=
 =?utf-8?B?RExFVW4rWG9aY0FjZFFJVDd3WWxDTUFwUkdlSUFYTWZOSloxRG0wNm5abXl4?=
 =?utf-8?B?TWtIZThtcDhxcVo1RGxqWTc3dzZMQi9NRzBiYWN3akdOYUY4YjhiS1Fmbm5x?=
 =?utf-8?B?eTVIU3R0MUxnWDlKNHVHQWJ4QzJ1dm16b0NwQVJrRVkrdkZsOTRRVkVPQnVS?=
 =?utf-8?B?alNjVnM0NUVCWHo3M2l4RmR3dWEvYzk3S0hUUDRyT1pTdm1zWjlHd3FQYkF0?=
 =?utf-8?B?UGlpZU1WTlVTTEdPaHNFTVIrQVRNMnFwREtXeGpUeUtNRnh5SXRuOUdjK1lV?=
 =?utf-8?B?K0VwT0xSZG5FT2JYS1NjVG8rQWhwYnlBbjlqaUZxamxMRlIzL2ZrNmwxVE9B?=
 =?utf-8?B?V1dtcHJYTGJYcTJ5QStKZC94V2Y0QUhaUnZsdlJ4dk5aMzNCVnVVMk0rN0pi?=
 =?utf-8?B?MytiY3JZQW5RTld6NUdWWGtkUXFKcUwxK1pZNWJoTjJpbldCQ3NodFBldnh0?=
 =?utf-8?B?QUsyczZRbStGWll5S0lMTmNTL2NYcmU3cnZwSUZZemwrdHRXVjlWaHVsaS9P?=
 =?utf-8?B?aW0xb2xXWWx2N3RCbTE1YnJnb1JlVWlLMVpZRFI0dS9LaVgxMmN2UE05dFJZ?=
 =?utf-8?B?M2x6NVpxZzZRVjNrajJpRFFWWHBVeHRsTTBSbW5JSVZuSzNDQ2k0SlViSTZI?=
 =?utf-8?B?Rk1EQmVXdUZYbVNlejJndm9ZQlMzeW1oTUdqL3dQVWNESjlTTXU3aVZNN2lJ?=
 =?utf-8?B?SHJxTjJVZnUyNTZDaEd5ZVVNQlBPSFVBTDNiWXVYWjdnOFlURkVScWd6ZFRY?=
 =?utf-8?B?V0IyN2tmZXkydE1MK3pHTTdBYlFUNGg5bjU2RTcyMHB4VHFyeGxXaGtIcVN4?=
 =?utf-8?B?a1p4Z3JpYmh2Zlg0OGRhR1dGSmpUKzhkUzRyNkszZ2FtaDNNM0lvY1hnejdp?=
 =?utf-8?B?ZFRMVzgxc2xrZWt5Y05oQ2pISWhtMG5jTU5vRG9FTGxuSm51blZNY2NvMXpK?=
 =?utf-8?B?cDQ2bk91a1RtckdQTlZzcVU5T0pTdkhxeUhKanJGOHJQNFJ4bDlPaUhLOUxI?=
 =?utf-8?B?VnRwbHV3RDJYMmVQY05lOHdleWhZUGc0aEcyM3dHanI5NUVocmczTU1qcDk1?=
 =?utf-8?B?Ynl6UE1jS1dpeUZONXJYVTliVUR2c2ZmVEo2dXpNbVJneXFpSEdMbUdHa0Fi?=
 =?utf-8?B?eHNOZHYxZERDVkdKOW1PZkJtbmtZYlR3QmZza1ZIUzJ4aVZDSlYxdml4NUVr?=
 =?utf-8?B?UkdhdloxcVpPeGRZMlZUWTh3Y1ZHMHVwNldQRk9UdlpVdFgyaitGWWwyYzVE?=
 =?utf-8?B?US9qbkdySExUc3dEYlRXZ1lJTlBHNUdJS3NQZmluZVovQS9Eak52RnpQWWUr?=
 =?utf-8?B?TmxoNUFQZm1oUjJ5Wnp2cC9abldxU1hPbVlUUGtQVVcrQzZtVVc5UWtVZ3RR?=
 =?utf-8?B?Qlg2UjFTU2Qzbko5QWpEWXhwM1pYQzlmRnB4eGo3QlpKM3p2WDhEViswV1p3?=
 =?utf-8?B?MkNpUlpZMlhlQWJkaGNrSGlZeER4TkFQNGVIazNCRk1abkFubXZKNGtVcEdG?=
 =?utf-8?B?QmxtdUpuZVRBZU9VR01Cc0FHSFNwYVNJZk9kVkdxVHVWTHNza0lrNklOczBS?=
 =?utf-8?B?MUNQdUdEWmpWUnVYRC9HWHdCSCtRRldtOWtJY1dPc1NCQTlYcUVyS2haemQ4?=
 =?utf-8?B?a2ppcUY0YWVVNzlXOGtFQWJTa3UweGVwcmFCTFRQQTBIOU1MeG1NTkdXSVcy?=
 =?utf-8?B?QTZsSzVzdi9GR0I2c1YvNkF1QU1TdC9vWFpkU0t0Z1hYWC9pQmw2ZGIxVTYz?=
 =?utf-8?B?RkdjaWlPZ3hyN1V6Z2lOMlRqL2Q2R3BzdXJzQTVoWUJsZG0yNnZJMkJua3py?=
 =?utf-8?B?aEtuMEFEUkNUUkdWaHlDejQxblo1TUc4THo1a3FucnRVSnZiZWlscmR0d2w2?=
 =?utf-8?B?TWV2NjBNd0dwVHVXY01nMlRPczJ6MzFMeWNDd2VOelBPRFBZVlRqUWN0VjRJ?=
 =?utf-8?B?N3FKd1pWNCtTV2RJSzdVNjNoc0RwYmZ4Sjc3bjBhMmZvYkhjdHRsNlplUjY3?=
 =?utf-8?Q?r0yrS1kaWJJZdEYek6A6xPJU7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13f9df7d-b20f-47f4-cd95-08dc5d7ef78b
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 19:05:08.2243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nEWjjfzt299bQCjiphAVaNKYdH+QEMea9YvXCXaDepCdRew8/3zqAGT1bfp9YIKFC8RzgW5v/umAk0sizrWMow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7966
X-OriginatorOrg: intel.com

Hi, Jonathan,


On 4/12/24 09:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
           s/busses/buses/

> parent to be the iDXD PCI Device.
                   s/iDXD/IDXD/
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Other than the typos,

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

> ---
>   drivers/dma/idxd/perfmon.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index fdda6d604262..fbb586eed0b3 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -477,6 +477,7 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>   	}
>   
>   	idxd_pmu->pmu.name		= idxd_pmu->name;
> +	idxd_pmu->pmu.parent		= &idxd_pmu->idxd->pdev->dev;
>   	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>   	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>   	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;

Thanks.

-Fenghua