Received-SPF: pass (google.com: domain of linux-kernel+bounces-145751-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6eec8880-798c-4835-becf-976cbf8fe72f@oracle.com>
Date: Mon, 15 Apr 2024 12:06:26 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] mm/hugetlb: convert dissolve_free_huge_pages() to
 folios
To: Vishal Moola <vishal.moola@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, willy@infradead.org, linmiaohe@huawei.com,
        jane.chu@oracle.com, muchun.song@linux.dev, nao.horiguchi@gmail.com,
        osalvador@suse.de
References: <20240412182139.120871-1-sidhartha.kumar@oracle.com>
 <Zh1xslaqduUr4MHF@fedora>
Content-Language: en-US
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Zh1xslaqduUr4MHF@fedora>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RmNDbXdHejRleTFxdGtYcEhGMXBxaWgzeFMrT0FFaEZNNlMvMWRFbmFiMHVx?=
 =?utf-8?B?YWFiNk96bGhHRVNQektTT3pPVXc3aUsvV25xanExT2tVemFTVEgwcVlQVHA4?=
 =?utf-8?B?Tnk0SHY4ZjI5alJtUy9mVzhFTTd3d2RvQ0U3WnQzbWZjSG1UdTM3NWZZWXdR?=
 =?utf-8?B?UFJwWko4OUpYRENVTlcyS0JFMXdYWEtxcW1USEJwcFFRY2dESUdoelMwTkRL?=
 =?utf-8?B?RzEzTFFpZzhqbDhSbzFITk5Pd0djWmdoNVkyRGRtOGZpWndUSWlTZi9VTFVR?=
 =?utf-8?B?NkZOT01nQzZwQXA4OU1zUkwvYlp5Znh6NEpMOEtJUVlKNEpKSENScDgvYldM?=
 =?utf-8?B?Q3I4S3FuZmd1ZnY2c1E1UHBSSFpJZ3J3c0VZTkU0MEwrR1B3M1I5TEpOTWFX?=
 =?utf-8?B?NmxuUHRHb2FJTDlEcE9sTDl5QXdnNnlFZGppV3ovS2k1M1FYVWFwUnFxQWgv?=
 =?utf-8?B?a3dVdysra2FQcVgwdTE2bUdYaDdVdm9GQzk3dVNxVStTdmtzcFFDeHY1aEVZ?=
 =?utf-8?B?ZkRhYzBiVU9nSGY3d2RrNlRqYS8xQks3VVZMNTc2VU5ldkg3azV2NlhvQy8w?=
 =?utf-8?B?MWkzYU1sZ0ZjOFBSbXp5TFJtQlFVRHIxYUM2clNIVDhyOHI0YWF5ZUU3SUxr?=
 =?utf-8?B?cktqYmpCeFVXUkVzd3B3K1U4eDJXUTRRN05Sd2VwK1NZblVraVlQVEd5VUFa?=
 =?utf-8?B?bElUUFB5SHpJMDhxN2IrS1g5MHlRT0J1aDFlVjJTelNGODVoSFpiUXY0VXlp?=
 =?utf-8?B?RTFJeDRnZmtaK0EyZi9ESHBqY3dkdi9kRnZnR0lSTVRwd3crZUlVUWM0Y2Fi?=
 =?utf-8?B?bGZZQmF5N241ZjdJMkYzcXZ4NWdEc2xUMGFxa29aSkFZMDZhNEgrUXFSSm84?=
 =?utf-8?B?UUhpVnN3emxTdWpOUTQyZDJZNFVuZ2NRdEJzbCt3Z01YWVZIWDhlZFc3NHVm?=
 =?utf-8?B?SlBUcitCMkFwOEZrZzJ5R0ttdjFkQW5kbVRkMy8xN3JmVU8zVEZiem9JaTgz?=
 =?utf-8?B?bFVLb2NlZHJBeFN6ZS9sbmNXU1NaZmQ1TFdtNEQ2N2FhNS9rUmxiWElDNmEy?=
 =?utf-8?B?YkNZN1NaSitkTUJiYWlQbnVhL1lNMjAyOCtvUE9kZ3h6L1M2b0VhRnU3TDQx?=
 =?utf-8?B?RXJYdDlYbVRnc3pXNE9zbWdkcGRDR1FubTZwOWVETVdIRU5aV1ViYUJRQlo3?=
 =?utf-8?B?citMdmEwS1Frbmc3V2svN3VKZm1qZm5ldUVGVUlzKzZMRDJPU2VsNWlaRS82?=
 =?utf-8?B?cGhTNjVpaDJxQzc2YU45T3N6emFCRVZQdDJ3RXFCVHpiNm5jMkdMUDA0ZmEv?=
 =?utf-8?B?elVIL3dYZWlUWjR5MGxDMk9aWmQzQXQ0ZUN6S3ZoK0tHK2ZPVEx1cXozT1hK?=
 =?utf-8?B?WlRpSUhSNFBiKzlJTHVidDNGMlgyejY4RjdHMy8zd04wbmVWT2Q5dzlEcGd4?=
 =?utf-8?B?NC83SjhVaUYySFZoTkFESkUyK3JmMzltd2xOUWdXVUhXUlgwQWlLa3hHMTNm?=
 =?utf-8?B?SjNDUnRmbHFBQjNVZEVCbE9WaiswWTh1YWxXY0ZNM0Iwck1YdS81a0xzM1BR?=
 =?utf-8?B?K1FINnBIUzBMM29QZm1lWFpGYktNRjRSTVErQzdwYkxvb2F3L0d0OGlOWE1r?=
 =?utf-8?B?WkQ5eFZMRWlzdnJUOXRUVmNIWllSdVhIUGhzM1FFYWpMZmJ3WTJBdW9BYnBa?=
 =?utf-8?B?NlE2SDYvWDVVeUl3ejJMb2YzNW9Ubm8rRHM1WWx1OFBBeEVRZG9HYzZtL0U0?=
 =?utf-8?B?ZytnUExPQ3VnOGtucU9ZTDhheHpZUjJ4cGpwYXBmSDludTlUaGE5bUdtcGxS?=
 =?utf-8?B?MStLSHU0TlNrWEg4TkwvNGZpT0hxdXFJcERsWW8zZHZWclhjb0xKVjFTWTV5?=
 =?utf-8?B?anczOTN0VytYTytGb2lNd2xxbDhaQ0RPaFMyRlVHZW9kUmF5RE5vOGtRZ0FR?=
 =?utf-8?B?MG1ycVJ4ZkhVbzF6dmZLVi9XMzJyM0ZTcFJKZHIwcFgvblpMS3BVWEFjZ29a?=
 =?utf-8?B?TEdzM3RiSDBrM0hKbEZzUkNYRWh1MUhtV2MwWXN6eTMrc0NQS3NnNEVQRUxU?=
 =?utf-8?B?REUzYWZTbUJSYWJ1RmJDMDdBTkJxUHpaZzNMVU8wUmxxQkhmc3dScEVnKytX?=
 =?utf-8?B?NkNYeDB3TVVnQVZRTUpQOWxOK1M0OTJDbzNCU3YvYkJDSGp1ODA3Q1FmSlNp?=
 =?utf-8?Q?tXOTOEo7R8qbP/7BiH7X7gk=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	hAc1M1AEhxv8z8BUmazy2kv5MBiKEASZFj40ilz9B5rrGJqqtsDVYuRSPBFzyS7Lm3pPO/iw9cwvO5EzZyajoEKvvR178RftqeI/k/cOarUDima3g6TO8U4U4rJaaEXieccFPWoAHC7QDaj0qvq5w7kIu9fWRGYHYhrNtvvshtikiWfsLOdX14m6clxqMfo83ZFDsIUM/C2xGiAAfATLyPtKQs/YQJoblrIZs9fdDyqavjdbgdZBq1ZOBHLftOg1/lTWdHOkrxHvYjvzzKBWn8UAVQ6iZA4k7AbJDwTaciuQNapJvyT8OVY7p2EDCvpKaGVIAfIZ2KO9dymX3hMkA/HmG+mJtZeGp0ZGtlN88WZ6GS8dYhPhq/9PU2X2K1m8TwsepRNyK1SXbzQrNvt1WyPyL/vn9iUZZOz/w3vngvLmyyFpycBjRlm3LFXaPaGE+qecnz46Sv3bUnpwSqecqloIencXiN1N6tps9ranQEZVwKX6YkXglX3ldDYk+QhPSkpspJJ8+gWb0KFQV3wILxG0CPHpPpHo+D7ww/9r1jDntuDg1v4LyTxPhlhYfJ9xxTgECpalUNxevpk5mxPJqZIlGnf7yT3aiYvpMRz0f+w=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df4a0013-ea13-436a-c9ed-08dc5d7f2820
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 19:06:29.7165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h2a05sNZDiPuPvlXo/M8CL4Qt7yMHHGvT/ClwdHZDYHIH+3+Ci2xi4iUSyJrrjM71qv4YQ6wWmrc7j3Pi4sepgdtxvBKwO3orMkizlIAPd8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6360
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-15_16,2024-04-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404150126
X-Proofpoint-ORIG-GUID: MjOwZISh7Z42r7KRgLCZqyASB5ayHMVI
X-Proofpoint-GUID: MjOwZISh7Z42r7KRgLCZqyASB5ayHMVI

On 4/15/24 11:28 AM, Vishal Moola wrote:
> On Fri, Apr 12, 2024 at 11:21:38AM -0700, Sidhartha Kumar wrote:
>> Allows us to rename dissolve_free_huge_pages() to
>> dissolve_free_hugetlb_folio(). Convert one caller to pass in a folio
>> directly and use page_folio() to convert the caller in mm/memory-failure.
>>
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>> Reviewed-by: Oscar Salvador <osalvador@suse.de>
>> ---
>>
>> v1 -> v2:
>> 	- Change additional comments which reference hugepages to
>> 	  hugetlb folios per Miaohe Lin.
>> 	- introduce patch 2
>>
>>   include/linux/hugetlb.h |  4 ++--
>>   mm/hugetlb.c            | 17 ++++++++---------
>>   mm/memory-failure.c     |  8 ++++----
>>   3 files changed, 14 insertions(+), 15 deletions(-)
>>
>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
>> index 3f3e628802792..f4191b10345d6 100644
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -861,7 +861,7 @@ static inline int hstate_index(struct hstate *h)
>>   	return h - hstates;
>>   }
>>   
>> -extern int dissolve_free_huge_page(struct page *page);
>> +extern int dissolve_free_hugetlb_folio(struct folio *folio);
> 
> You could drop the extern here as we don't need it anymore. Aside from that
> LGTM.
> 
> Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> 
Hi Andrew,

Could this diff be folded in this patch to remove the extern per Vishal.

Thanks,
Sid

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index f4191b10345d6..4cd7895590b6c 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -862,7 +862,7 @@ static inline int hstate_index(struct hstate *h)
  }

  extern int dissolve_free_hugetlb_folio(struct folio *folio);
-extern int dissolve_free_huge_pages(unsigned long start_pfn,
+int dissolve_free_huge_pages(unsigned long start_pfn,
                                     unsigned long end_pfn);

  #ifdef CONFIG_MEMORY_FAILURE