Received-SPF: pass (google.com: domain of linux-kernel+bounces-145769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1158f240-ea6b-4ac7-9697-a30d27311c50@linaro.org>
Date: Mon, 15 Apr 2024 21:31:44 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mfd: pm8xxx: add support for PM8901
To: Herman van Hazendonk <github.com@herrie.org>, andersson@kernel.org
Cc: benwolsieffer@gmail.com, chris.chapuis@gmail.com,
 Lee Jones <lee@kernel.org>, linux-arm-msm@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20240415123941.1527938-1-github.com@herrie.org>
Content-Language: en-US
From: Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20240415123941.1527938-1-github.com@herrie.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/15/24 14:39, Herman van Hazendonk wrote:
> Add support for the pm8901 PMIC used by msm8660.
> 
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
>   drivers/mfd/qcom-pm8xxx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> index 8b6285f687da..9cca14d54d8d 100644
> --- a/drivers/mfd/qcom-pm8xxx.c
> +++ b/drivers/mfd/qcom-pm8xxx.c
> @@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
>   static const struct of_device_id pm8xxx_id_table[] = {
>   	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
>   	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
> +	{ .compatible = "qcom,pm8901", .data = &pm8xxx_data},
>   	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},

Please refrain from adding this new compatible, instead add a new,
generic one and modify the dt-bindings such that we go like:

compatible = "qcom,pm8901", "qcom,pm8xxx-ssbi-pmic"

(or similar, +CC Krzysztof, please chime in)

Konrad