Received-SPF: pass (google.com: domain of linux-kernel+bounces-145884-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ffe13eb0-e7b8-4006-a7fd-7cdb4511cb9b@amd.com>
Date: Mon, 15 Apr 2024 15:43:25 -0500
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v1 27/31] x86/resctrl: Rename resctrl_sched_in() to begin
 resctrl_arch_
Reply-To: babu.moger@amd.com
To: James Morse <james.morse@arm.com>, x86@kernel.org,
 linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
 shameerali.kolothum.thodi@huawei.com,
 D Scott Phillips OS <scott@os.amperecomputing.com>,
 carl@os.amperecomputing.com, lcherian@marvell.com,
 bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
 baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
 Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
 dfustini@baylibre.com, amitsinght@marvell.com,
 David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>,
 Dave Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-28-james.morse@arm.com>
Content-Language: en-US
In-Reply-To: <20240321165106.31602-28-james.morse@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VGJOdWdZaHAxNDJTeGpGT2c4YkVlTUhpUjA2T0Vvd0lsdTFxTGd4ZlZUNi9k?=
 =?utf-8?B?RkZoa3VYWFplRFJYaGlVSXdWUXpWKytaZzZTZFY4RHJxUkNlL3dKQjFrNDRq?=
 =?utf-8?B?c3dvWCtsMmVrcWp3RXdydW5NREdIdjlCYStiaUtuWSt5Nit5ZmpjWFEzQkhr?=
 =?utf-8?B?ZGZnUmRvUnYwTlN2VkRrMGxiNEZXSEp0dDZlaGxTakZtMWFNNnYvNjRuQXAz?=
 =?utf-8?B?SEZvTHFXYnlvQnYyUFFzajlUanpyQnQ5Qi90cEdXbU5aS21QWklEbXlYaVRo?=
 =?utf-8?B?K0RrdnlMeGI3eGZwNkFtaEdycHZGYS91K0c1TUhML2JSd2s5Q01TREhNVTFH?=
 =?utf-8?B?ckpxdTlYM3hOa2hNZ05WQlF0REF0elAwVi9yS21tZTN3UVRmaGRCaldnbk5E?=
 =?utf-8?B?RHJ4Lzc5NE0zNm45VElGanpPa3RlbDY0QmxRajd1MTFkSmdBYzNxWmZ6c05E?=
 =?utf-8?B?OWUwbEsyc3d1bHc3cU1CZEVjbVhZakhaZUgxbFJBakZhREVROFgwdTdtbHY3?=
 =?utf-8?B?L0RmekJwUlRrb0t0enNJcHBoRGRSL2dIOW13ZkpWNkxxOGx3M20xakVuQzh0?=
 =?utf-8?B?amE0Z2UwRlM1aS9MTXI2OCtVYWJlQkZDWWtXOWdReUJWbkljcTd0eEV4T2FU?=
 =?utf-8?B?MUVGTmI1K2pzdlVUb1MzQitEQkhXMW9TaVpMSEpOSVJBNFlabE1BUzdpZ2Zp?=
 =?utf-8?B?QlVGazFmU1hvc1FET1F4dVVtaUNGZ2ExRFNCdjA1TVkyWW9vWVBVVjhRSHl2?=
 =?utf-8?B?OFNPcWFxZWx6SG1Rc0QxSXZMT2NDaDFXeG9abTltdTd4SFRjemJlMnY0a2NO?=
 =?utf-8?B?Mjhmc3p6YU5kYmRIdWJQS0NBNFMydzNDcC80MjlDZG4rTTQ0QW5zZjBudXFp?=
 =?utf-8?B?bEdaU25Xem10a0tXaDI5MG9JdjhiN1VMQjZ4NnlBTnIvNG5DamNUMllzWjhT?=
 =?utf-8?B?NStKYVBDcVpvazUrQUN2VHozcDladytOeFdmdHE2aEo4bU9RNGo1R2QvaG5S?=
 =?utf-8?B?eVBFTEJjWEYxUS9ZS0dBaXBCeldIblRzUVh0MTZNbmdZSkY2Lzd3ZXVCMW90?=
 =?utf-8?B?VHFxYVZscXdtZ0tZV3pNR1Q5QmxmYmxzL0Z5ZWcxTjROQkRmN3VhK0Z4VFF6?=
 =?utf-8?B?UmNRNGVPdVdWSHlsY0Y5VytMYkFMMTlGaWExRFhJazJiMkQvdFhNUGJpOUVG?=
 =?utf-8?B?RXQ4R0tVSlg5djFtdEZOU2U4WjloYzdtaUhhcllrLy9lRTFoQmNoWjVGeXVL?=
 =?utf-8?B?VG50UjJrZ3lvd0ZUSmJ3MWlKdmdpYkVHaCtXL3BaSnErNnpmR016ZmNhejZi?=
 =?utf-8?B?b3hNSHE4VEhLS0dpSGVPU3lRaUpOU3FhMVlXeUZkOXFEZ0FNZWhyWk1kNlBU?=
 =?utf-8?B?RC95Y2xZWnA5NnRweStnQzU1c1RTd0ZxLzhNdThIMHJaN0IyK2xuNDZKbWpi?=
 =?utf-8?B?R3RiWnFGeG9LQ0RoNGljdHdabWpZcjY2ZDYwdVlQL2pvVFI4cWxKYW1FRXhZ?=
 =?utf-8?B?QVI5dnI0bVdXMzVnQjc2U1d4NHpLQWR5ZXR0Mk5rZXFTWmhIcmRjLzVyY1N1?=
 =?utf-8?B?amNFUnVlUHJBTVNYZ1ViVE16NE5MaVBQRXhRcVNPbDAxbHNybzlpTUU1UmJu?=
 =?utf-8?B?cnZqQS9NUjI0ZTllckI4Ykl3NnR2WndMdi9TcTdndXVoa0Y1Rk5STXlUMzdn?=
 =?utf-8?B?ZDhYa1VMc3pocXJIazdKTWd6Y2NQaFZ2blFaYWxmWEQxcG5YZFhhQnVndnNW?=
 =?utf-8?B?TFhHeGlzM29zVzBRUjJ3SnVGQnh6M0tscVZGdml0eXdXK3NlZjh1WGc5TmJJ?=
 =?utf-8?B?eDVkajFqd1h5c0dDN1pyZ2k5ZjlzU1EwdXFhQnNiLzV3cCt0UjNXYU5ad3k5?=
 =?utf-8?B?NGRMaW1XTFlrR25qSEg4ZVlkZGFIUi84N2UrQXJiZU5CUUFHTXpXMmtDZE40?=
 =?utf-8?B?WGxwZEdidkdTNEJhYyt2N3FQcC9JM1ZhUlhFa3k5OXdkMmJEQlc0OUF4MWll?=
 =?utf-8?B?aWJRUGw5WGdZd1YySUkzbnVKMTJhNU1Ib2VaV3hmWjA4aUR3eHNseXlIVVlX?=
 =?utf-8?B?cFRuRG1LMnQ1TmJEVThJeWJCNDdFN1JibmdvQlJDb2VFYm5uMUo0a1VxMkJm?=
 =?utf-8?Q?s9OY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b74cf72d-86cd-4c87-5074-08dc5d8cb507
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 20:43:29.4844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wCrsXTx+bi5M1czjxZ5AYtGY7FEVoFXjp+mhH8p+vBUhCuqyERbRJA8I/IfWENal
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6356


On 3/21/24 11:51, James Morse wrote:
> resctrl_sched_in() loads the architecture specific CPU MSRs with the
> CLOSID and RMID values. This function was named before resctrl was
> split to have architecture specific code, and generic filesystem code.
> 
> This function is obviously architecture specific, but does not begin
> with 'resctrl_arch_', making it the odd one out in the functions an
> architecture needs to support to enable resctrl.
> 
> Rename it for concistency. This is purely cosmetic.

s/concistency/consistency

> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  arch/x86/include/asm/resctrl.h         |  4 ++--
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 12 ++++++------
>  arch/x86/kernel/process_32.c           |  2 +-
>  arch/x86/kernel/process_64.c           |  2 +-
>  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
> index 9940398e367e..491342f56811 100644
> --- a/arch/x86/include/asm/resctrl.h
> +++ b/arch/x86/include/asm/resctrl.h
> @@ -177,7 +177,7 @@ static inline bool resctrl_arch_match_rmid(struct task_struct *tsk, u32 ignored,
>  	return READ_ONCE(tsk->rmid) == rmid;
>  }
>  
> -static inline void resctrl_sched_in(struct task_struct *tsk)
> +static inline void resctrl_arch_sched_in(struct task_struct *tsk)
>  {
>  	if (static_branch_likely(&rdt_enable_key))
>  		__resctrl_sched_in(tsk);
> @@ -220,7 +220,7 @@ void resctrl_cpu_detect(struct cpuinfo_x86 *c);
>  
>  #else
>  
> -static inline void resctrl_sched_in(struct task_struct *tsk) {}
> +static inline void resctrl_arch_sched_in(struct task_struct *tsk) {}
>  static inline void resctrl_cpu_detect(struct cpuinfo_x86 *c) {}
>  
>  #endif /* CONFIG_X86_CPU_RESCTRL */
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 085fb9c2333a..218aebd6387f 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -359,7 +359,7 @@ static int rdtgroup_cpus_show(struct kernfs_open_file *of,
>  }
>  
>  /*
> - * This is safe against resctrl_sched_in() called from __switch_to()
> + * This is safe against resctrl_arch_sched_in() called from __switch_to()
>   * because __switch_to() is executed with interrupts disabled. A local call
>   * from update_closid_rmid() is protected against __switch_to() because
>   * preemption is disabled.
> @@ -378,7 +378,7 @@ void resctrl_arch_sync_cpu_defaults(void *info)
>  	 * executing task might have its own closid selected. Just reuse
>  	 * the context switch code.
>  	 */
> -	resctrl_sched_in(current);
> +	resctrl_arch_sched_in(current);
>  }
>  
>  /*
> @@ -605,7 +605,7 @@ static void _update_task_closid_rmid(void *task)
>  	 * Otherwise, the MSR is updated when the task is scheduled in.
>  	 */
>  	if (task == current)
> -		resctrl_sched_in(task);
> +		resctrl_arch_sched_in(task);
>  }
>  
>  static void update_task_closid_rmid(struct task_struct *t)
> @@ -663,7 +663,7 @@ static int __rdtgroup_move_task(struct task_struct *tsk,
>  	 * Ensure the task's closid and rmid are written before determining if
>  	 * the task is current that will decide if it will be interrupted.
>  	 * This pairs with the full barrier between the rq->curr update and
> -	 * resctrl_sched_in() during context switch.
> +	 * resctrl_arch_sched_in() during context switch.
>  	 */
>  	smp_mb();
>  
> @@ -2946,8 +2946,8 @@ static void rdt_move_group_tasks(struct rdtgroup *from, struct rdtgroup *to,
>  			/*
>  			 * Order the closid/rmid stores above before the loads
>  			 * in task_curr(). This pairs with the full barrier
> -			 * between the rq->curr update and resctrl_sched_in()
> -			 * during context switch.
> +			 * between the rq->curr update and
> +			 * resctrl_arch_sched_in() during context switch.
>  			 */
>  			smp_mb();
>  
> diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
> index 0917c7f25720..8697b02dabf1 100644
> --- a/arch/x86/kernel/process_32.c
> +++ b/arch/x86/kernel/process_32.c
> @@ -211,7 +211,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
>  	switch_fpu_finish(next_p);
>  
>  	/* Load the Intel cache allocation PQR MSR. */
> -	resctrl_sched_in(next_p);
> +	resctrl_arch_sched_in(next_p);
>  
>  	return prev_p;
>  }
> diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
> index 7062b84dd467..d1cf885e8930 100644
> --- a/arch/x86/kernel/process_64.c
> +++ b/arch/x86/kernel/process_64.c
> @@ -707,7 +707,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
>  	}
>  
>  	/* Load the Intel cache allocation PQR MSR. */
> -	resctrl_sched_in(next_p);
> +	resctrl_arch_sched_in(next_p);
>  
>  	return prev_p;
>  }

-- 
Thanks
Babu Moger