Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1684551lqp; Mon, 15 Apr 2024 13:54:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUP5KfCHMZYiKqwusuWJ7l7WAux/u6DYd+jyzuYVE0BGVE/ciyW3kKABLNNUKIrK97uRXJ1KKVcb6OkjzA5IBEF5r4arN8zhgnHEeoawg== X-Google-Smtp-Source: AGHT+IEtpnkJQq/WESXSxBK8xjRm0ucYT7UVHXBNGuqxBqoZsf8c1irBZVWfZJqOO1UQ40kEX//1 X-Received: by 2002:a17:903:32ca:b0:1e5:9dff:a52c with SMTP id i10-20020a17090332ca00b001e59dffa52cmr11082564plr.10.1713214463555; Mon, 15 Apr 2024 13:54:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713214463; cv=pass; d=google.com; s=arc-20160816; b=WWEqKNiClmyhWGqe3Hz5eX65QH877quVGeddHuxqnNsgUwcTrqS8t1vkKZF1cDGDDs QKwDiU0vcCIzuG6cYkyLyU+Z1ppuB72PriRNbkwq4uKmYlhj7djcPxl+cLtHGgL+pDp8 NVCEdMzO+6s6U7iwEQYY0znQcckSRUor3NQ1CObQZaMCCZ1lockyEcj7vMmF40k6ENUM msHnq7sEIEa34RE8X8PnLjRerja5qRP4h6TuQT0fz/wJdRTPipSq8AEkz2WCjBM4gxGI jik+0/HrMPusavEo4LML8iRFk+Wa3cElTBFC/0Gc4+TJ/kRrU8t/keL3ZIT8inXaInh9 UKZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rnJS4iLvWMZBAl+srbE+a8Sb/L1BgVqPSwDcYoSU4Sg=; fh=muBNuBabrCeMTvN074K01pYKF1kkCLjL35zzmgMhusc=; b=MOpb0dHpwmp540BvqaXaM4S0WXaqbHgY1Jb34XKADkdEHcWqf9umL/ul8N5qYi8fKJ e9ejU0C9hrLAvdSD9waoiOJfRmVOjj17YWFosQOZYnTqfx4aYuBQ6f1aiKB6NliGNCk4 Rkfbsda6RW7vHexd/LCE0uQFJE3BXHtazQZL9d85RXJrc6tf7MrTf4gbzrkExNvpOubv HaO2zHIcBO7ucUKpbMuFjfDlW48BuYlw2MnFclJ1V+BO/Beu3kDTEc9L5oD3MrHU0f5G sKFq8h6YcL30iQGRMd0QdF45JhzI/GQrZMdHAFE5OnPa6VXlWj0i2S8hizU8QV5VDFUD Lp/g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GJ9BTXPZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145896-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l2-20020a170902f68200b001dd38bd5f72si8751403plg.614.2024.04.15.13.54.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 13:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145896-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GJ9BTXPZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145896-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44A1A283450 for ; Mon, 15 Apr 2024 20:54:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C3D3156978; Mon, 15 Apr 2024 20:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GJ9BTXPZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE361DFEB; Mon, 15 Apr 2024 20:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713214456; cv=none; b=a+5RD1NM2Y44flBUTLm8CmnlSdAMBKxM+SOfIk6yV05RnhbFTL3M2wRNqQssM7b8Cm2RxZqvRh69Ms3abmCbfE80zAYCQqtDq7ksJy6noyOZXtmL8oQjmatu8o2l22lLyIeGSGRTlTSutM1qw5P5n3XPbxQQsikVRfMlLumbpqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713214456; c=relaxed/simple; bh=VbQJ+rdQSN7sFgw0qz8nrxe7EDMb6/hAklXEgP8FwKs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Trjt4hWBE0oLTqHCNtwITw2icS96dqpF2VZf0e4lnQzxBB4uVUwdCnF7K9giftq47ztQq/Z09xodmtJCTm8ww4N+leyooDKC+RCO+UDWOhfIcbukTW3HgngaWWSlRTzjqs/YqIXIxpekyz39z3Yt6nx26tG/bW1w7YQZL7Ty8ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GJ9BTXPZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC5D5C113CC; Mon, 15 Apr 2024 20:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713214456; bh=VbQJ+rdQSN7sFgw0qz8nrxe7EDMb6/hAklXEgP8FwKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GJ9BTXPZ/JccPVsrJoBsadqpbwEUIspktXepgpPesgnBZm2m6DMBkp0NpDpQF6vso T8B2cOU4nWbZBZRwDZRpCrl1/DSVNtJIyqbSy6/meyRW9htR5LTOH1JgBLWzBdJ3nQ KM9oZM42Gi5/JpUalipYNU7O/LH5zzNfQTZ25A1JoIO2G13lP+joRIYW+XZXpFSgxx 9tffy3O+c6YqLIbR7Pa5GPn/Z7kw7t9SeGEjXJ41bVdirreC1yi67u1bx5Kkuh4ZZg FVyar8GPZG432l97qjKLAGuLaqZPwPsIiFUlBSXCH8175uUgOWyZ9orEtZKWLmBQTA 7Q76FpVZhpDiA== Date: Mon, 15 Apr 2024 22:54:12 +0200 From: Andi Shyti To: Abhinav Jain Cc: chris.packham@alliedtelesis.co.nz, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com, Julia Lawall Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Message-ID: References: <20240415161220.8347-1-jain.abhinav177@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415161220.8347-1-jain.abhinav177@gmail.com> Hi Abhinav, > /* Enable I2C interrupts for mpc5121 */ > - node_ctrl = of_find_compatible_node(NULL, NULL, > - "fsl,mpc5121-i2c-ctrl"); > + struct device_node *node_ctrl __free(device_node) = How have you tested this? Andi