Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967AbYAXRBH (ORCPT ); Thu, 24 Jan 2008 12:01:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756769AbYAXQ6l (ORCPT ); Thu, 24 Jan 2008 11:58:41 -0500 Received: from mx1.redhat.com ([66.187.233.31]:49776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756202AbYAXQ6i (ORCPT ); Thu, 24 Jan 2008 11:58:38 -0500 From: David Teigland To: linux-kernel@vger.kernel.org Cc: Patrick Caulfeld Subject: [PATCH 05/19] dlm: close othercons Date: Thu, 24 Jan 2008 10:50:28 -0600 Message-Id: <1201193442-8260-6-git-send-email-teigland@redhat.com> X-Mailer: git-send-email 1.5.3.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 42 From: Patrick Caulfeld This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down. This results in the error message "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all objects" and the DLM cannot be restarted without a system reboot. See bz#428119 Signed-off-by: Patrick Caulfield Signed-off-by: Fabio M. Di Nitto Signed-off-by: David Teigland --- fs/dlm/lowcomms.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 5772844..7c1e5e5 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1437,6 +1437,8 @@ void dlm_lowcomms_stop(void) con = __nodeid2con(i, 0); if (con) { close_connection(con, true); + if (con->othercon) + kmem_cache_free(con_cache, con->othercon); kmem_cache_free(con_cache, con); } } -- 1.5.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/