Received-SPF: pass (google.com: domain of linux-kernel+bounces-145931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <83dbc057-be42-41d6-95a3-af4b01d64afb@quicinc.com>
Date: Mon, 15 Apr 2024 14:26:10 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH bpf-next v3 1/2] net: Rename mono_delivery_time to
 tstamp_type for scalabilty
Content-Language: en-US
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        "David S. Miller"
	<davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Andrew Halaney <ahalaney@redhat.com>,
        "Martin
 KaFai Lau" <martin.lau@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>
CC: <kernel@quicinc.com>
References: <20240412210125.1780574-1-quic_abchauha@quicinc.com>
 <20240412210125.1780574-2-quic_abchauha@quicinc.com>
 <661ad4f0e3766_3be9a7294a1@willemb.c.googlers.com.notmuch>
 <c992e03b-eee5-471a-9002-f35bdfa1be2d@quicinc.com>
 <661d92391de45_30101294f2@willemb.c.googlers.com.notmuch>
 <6bfee126-36f4-4595-950e-058d93303362@quicinc.com>
 <661d9a8bb862c_314dd2942c@willemb.c.googlers.com.notmuch>
From: "Abhishek Chauhan (ABC)" <quic_abchauha@quicinc.com>
In-Reply-To: <661d9a8bb862c_314dd2942c@willemb.c.googlers.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 4/15/2024 2:22 PM, Willem de Bruijn wrote:
>>>>>>  static inline void skb_set_delivery_time(struct sk_buff *skb, ktime_t kt,
>>>>>> -					 bool mono)
>>>>>> +					  u8 tstamp_type)
>>>>>>  {
>>>>>>  	skb->tstamp = kt;
>>>>>> -	skb->mono_delivery_time = kt && mono;
>>>>>> +
>>>>>> +	switch (tstamp_type) {
>>>>>> +	case CLOCK_REAL:
>>>>>> +		skb->tstamp_type = CLOCK_REAL;
>>>>>> +		break;
>>>>>> +	case CLOCK_MONO:
>>>>>> +		skb->tstamp_type = kt && tstamp_type;
>>>>>> +		break;
>>>>>> +	}
>>>>>
>>>>> Technically this leaves the tstamp_type undefined if (skb, 0, CLOCK_REAL)
>>>> Do you think i should be checking for valid value of tstamp before setting the tstamp_type ? Only then set it. 
>>>
>>> A kt of 0 is interpreted as resetting the type. That should probably
>>> be maintained.
>>>
>>> For SO_TIMESTAMPING, a mono delivery time of 0 does have some meaning.
>>> In __sock_recv_timestamp:
>>>
>>>         /* Race occurred between timestamp enabling and packet
>>>            receiving.  Fill in the current time for now. */
>>>         if (need_software_tstamp && skb->tstamp == 0) {
>>>                 __net_timestamp(skb);
>>>                 false_tstamp = 1;
>>>         }
>>
>> Well in that case the above logic still resets the tstamp and sets the tstamp_type to CLOCK_REAL(value 0). 
>> Anyway the tstamp_type will be 0 to begin with. 
>> The logic is still inline with previous implementation, because previously if kt was 0 then kt && mono sets the tstamp_type (previously called as mono_delivery_time) to 0 (i.e SKB_CLOCK_REAL). 
> 
> Sorry, I got my defaults confused. If we maintain that a zero tstamp
> resets the type, then here should be no case with skb->tstamp 0 and
> skb->tstamp_type SKB_CLOCK_REAL (or SKB_CLOCK_TAI or whatever). I
> think it's preferable to make that obvious in the
> skb_set_delivery_time implementation, rather than depend on knowledge
> of its callers.

Noted!. I will do the same as part of the next patchset.