Received-SPF: pass (google.com: domain of linux-kernel+bounces-145941-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [kpsingh:static_calls] [security] 9e15595ed0:
 Kernel_panic-not_syncing:lsm_static_call_init-Ran_out_of_static_slots
From: KP Singh <kpsingh@kernel.org>
In-Reply-To: <0a4ebcd2-7772-4832-885d-221e0c6f6c04@schaufler-ca.com>
Date: Mon, 15 Apr 2024 23:39:08 +0200
Cc: Paul Moore <paul@paul-moore.com>,
 Andrii Nakryiko <andrii@kernel.org>,
 Kees Cook <keescook@chromium.org>,
 Song Liu <song@kernel.org>,
 Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
 kernel test robot <oliver.sang@intel.com>,
 linux-kernel@vger.kernel.org,
 linux-security-module@vger.kernel.org,
 lkp@intel.com,
 oe-lkp@lists.linux.dev
Content-Transfer-Encoding: quoted-printable
Message-Id: <11DA2A00-28F4-44F8-BBA7-012400FE1050@kernel.org>
References: <202404151225.ce542e38-lkp@intel.com>
 <757538DA-07A4-4332-BAFA-B864BFD06A76@kernel.org>
 <30876b80-c437-4916-b982-97c1a95c0747@I-love.SAKURA.ne.jp>
 <CAHC9VhS=hQuvv+Sw6cc2HwzcLApO7Rc3dAnqHytyzBpC1rokFA@mail.gmail.com>
 <CACYkzJ4G7hO0DNSBy4wpJG1PSgNkifuYcfOeTTpyVBtBtWvQSg@mail.gmail.com>
 <A9568514-FCB3-4715-9794-696383B2B7E8@kernel.org>
 <CD57788C-C9D6-4BA8-8352-90EBB6600D39@kernel.org>
 <0a4ebcd2-7772-4832-885d-221e0c6f6c04@schaufler-ca.com>
To: Casey Schaufler <casey@schaufler-ca.com>


> On 15 Apr 2024, at 22:54, Casey Schaufler <casey@schaufler-ca.com> =
wrote:
>=20
> On 4/15/2024 1:42 PM, KP Singh wrote:
>>=20
>>> On 15 Apr 2024, at 17:47, KP Singh <kpsingh@kernel.org> wrote:
>>>=20
>>>=20
>> [...]
>>=20
>>>> <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>>>> On 2024/04/15 17:26, KP Singh wrote:
>>>>>> This seems like an odd config which does not enable STATIC_CALL, =
I am going to
>>>>>> make CONFIG_SECURITY depend on CONFIG_STATIC_CALL and make the =
dependency explicit.
>>>>> If CONFIG_SECURITY depends on CONFIG_STATIC_CALL, architectures =
which do not
>>>>> support CONFIG_STATIC_CALL can no longer use LSM ? That sounds a =
bad dependency.
>>>> Agreed.  If the arch doesn't support static calls we need a =
fallback
>>>> solution for the LSM that is no worse than what we have now, and
>>>> preferably would still solve the issue of the BPF hooks active even
>>>> where this is no BPF program attached.
>>> Actually I take it back, when CONFIG_STATIC_CALL is not available, =
the implementation falls back to an indirect call. This crash is =
unrelated, I will debug further and post back.
>> Apparently, when I smoke tested, I had CONFIG_IMA disabled so did not =
hit the bug. Well, now IMA is an LSM, so the following fixes it:
>=20
> You'll want CONFIG_EVM as well, I bet.

Indeed, thanks Casey!