Received-SPF: pass (google.com: domain of linux-kernel+bounces-145957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 15 Apr 2024 14:52:48 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>,
	Jean-Christophe Trotin <jean-christophe.trotin@foss.st.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 6/6] media: touchscreen: sur40: convert le16 to cpu
 before use
Message-ID: <Zh2hsNpoaYs7GvCN@google.com>
References: <20240410-smatch-v1-0-785d009a852b@chromium.org>
 <20240410-smatch-v1-6-785d009a852b@chromium.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240410-smatch-v1-6-785d009a852b@chromium.org>

On Wed, Apr 10, 2024 at 09:54:43PM +0000, Ricardo Ribalda wrote:
> Smatch found this issue:
> drivers/input/touchscreen/sur40.c:424:55: warning: incorrect type in argument 2 (different base types)
> drivers/input/touchscreen/sur40.c:424:55:    expected int key
> drivers/input/touchscreen/sur40.c:424:55:    got restricted __le16 [usertype] blob_id
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/input/touchscreen/sur40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index ae3aab4283370..5f2cf8881e724 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -421,7 +421,7 @@ static void sur40_report_blob(struct sur40_blob *blob, struct input_dev *input)
>  	if (blob->type != SUR40_TOUCH)
>  		return;
>  
> -	slotnum = input_mt_get_slot_by_key(input, blob->blob_id);
> +	slotnum = input_mt_get_slot_by_key(input, le16_to_cpu(blob->blob_id));

We are not really using the real value of the ID for computations but only
as an opaque "key", so doing the conversion is not strictly necessary,
but it is cheap so we may as well do it.

>  	if (slotnum < 0 || slotnum >= MAX_CONTACTS)
>  		return;

Applied, thank you.

-- 
Dmitry