Received-SPF: pass (google.com: domain of linux-kernel+bounces-145965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Apr 2024 00:11:03 +0200
From: Andi Shyti <andi.shyti@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, 
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, alistair@popple.id.au, 
	joel@jms.id.au, jk@ozlabs.org, robh@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lakshmiy@us.ibmcom
Subject: Re: [PATCH v2 25/31] i2c: fsi: Calculate clock divider from local
 bus frequency
Message-ID: <q6bl7sbskt4ukd3mylfgwpo6dmv444umdpycs6xp7ozd2kv335@syeymu62fczb>
References: <20240226165321.91976-1-eajames@linux.ibm.com>
 <20240226165321.91976-26-eajames@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226165321.91976-26-eajames@linux.ibm.com>

Hi Eddie,

> @@ -689,6 +692,20 @@ static int fsi_i2c_probe(struct device *dev)
>  	mutex_init(&i2c->lock);
>  	i2c->fsi = to_fsi_dev(dev);
>  	INIT_LIST_HEAD(&i2c->ports);
> +	i2c->clock_div = I2C_DEFAULT_CLK_DIV;
> +
> +	lbus = fsi_device_local_bus_frequency(i2c->fsi);
> +	if (lbus) {
> +		u32 clock = I2C_DEFAULT_CLK_RATE;

I don't see the need for initialization.

> +
> +		if (!device_property_read_u32(dev, "clock-frequency", &clock)) {
> +			if (!clock)
> +				clock = I2C_DEFAULT_CLK_RATE;
> +		}

no need for brackets.

> +
> +		// i2c clock rate = local bus clock / (4 * (i2c clock div + 1))

You forgot to remove this.

Andi

> +		i2c->clock_div = (((lbus + (clock - 1)) / clock) / 4) - 1;
> +	}
>  
>  	rc = fsi_i2c_dev_init(i2c);
>  	if (rc)
> -- 
> 2.39.3
>