Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1716964lqp; Mon, 15 Apr 2024 15:14:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXAsXjz/mpBWTkTjCCllMno9MEHEDZSe2mVWtkwfEcmzrvtStR7VXGm7ePW/DDtg/yUyR/2tl2I/BBbgvfQnfi6Pg1GVvULHejtPIZcXA== X-Google-Smtp-Source: AGHT+IEJYxdsGU9se/yy4ocCN3gIs6ZKVz7zf27ENEBOOG122jCs9gR+DFvqjkjJn9OV80RfttuY X-Received: by 2002:a17:902:7208:b0:1e5:1158:74f6 with SMTP id ba8-20020a170902720800b001e5115874f6mr12142183plb.66.1713219262133; Mon, 15 Apr 2024 15:14:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713219262; cv=pass; d=google.com; s=arc-20160816; b=A8yOrggIFywA94g6uIrioLqpMeV7Yw4FG+jUhTZ2hzsobzrX0Af3K8qMe2/nr4QGza 9aFwYU1LLyZS0LKpAIqbK5GI16QgMZE2AOV6IRPixavzg9X78Gt2PWG9O1/JrorxNhM5 Rhg9PDu4o1k0QHN58LIcQ+OTGiCvY4ptGpXUtSN8nk9JaR2BM4jLAcmrVHYuxbPW2SfK cp1GtGlbV4AtjEGneIoKN+1dtOPwNw3o7ovtYCf1WY6fIWVMXLHUvzh6FmbVawgulHRs KjODtX2eCygDD+sbnMNlT6poX6/9sISq2+ymm6HgSdxe7p0bkzChGRDOS3Qgs+MI7LVA +GTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=26oxSnJXJHMA9f77hvIZs4zBgyNf1e+BFsA+b05GPLo=; fh=PldbcUGQh0mM/zw+lh6z+/Yg5wq6FFmatV4+8wMucbM=; b=TW89Y9qhbaGmy7mrn21JSByAjpTL6jFVioysjJzu6RQgBWn4A09YMk8xNTudiRDyqU mkE+JgcT9e91jYtIMVELN3m1HQupl57du6sZ5dkpp88Aqwo/sUhonQZvu5KfcDb6aZkm bSI/5WudC9GVtTqqILAwyTMM6Os+4xUzenC0D6qjctjxVKEmW73cx+k2b8Nx4fogxhB3 Jv5Ypo9K2mZ1/o32mwgefgF/F+vtID+GK2amn/ob9hKs+5bYZwNefQ6VSdo0THCdxMMQ AoHdIHkNk+pbNQqcqV7uywb78NDllDJpDx89sQnGr49NIkIGLfss5vHDrBedD85E0TwS 1+NA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IpT0mfL9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id e13-20020a17090301cd00b001e01baf194asi8585288plh.472.2024.04.15.15.14.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 15:14:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-145967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IpT0mfL9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-145967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-145967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A2D47B21462 for ; Mon, 15 Apr 2024 22:14:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC50A157E6F; Mon, 15 Apr 2024 22:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IpT0mfL9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B85725601; Mon, 15 Apr 2024 22:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713219242; cv=none; b=W5kUhSI4bAcdGq9y07lEzjHsl07JLYXyenip6JP8aFrPHHo18MgILaqFTnzpdzukYWhIuZil1NW7s9pd8uuDr92imiEGWMQJssSGArNt6+FZ59imi2d3HmbhS9umeCS0DSfiaVATtRcjgqfC/AY2xsZv87AEOfjnk7ax6bYu43Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713219242; c=relaxed/simple; bh=26oxSnJXJHMA9f77hvIZs4zBgyNf1e+BFsA+b05GPLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kai6ElpQIV/PLsHpj1BqLlegzVYfFZwoZlp6BPr2n5PSfNQXK+DfBrYN0JOOa+bJV+V1P7rsQY6Qh4s2UPLPpuCU7GYlW2Y1RDy6gyyRXPF3vahzUgAfff6YEdzx3qxzGAZIXYDDu3+zUr+I4AEHwZ60x8vUb1X+/66gwk4lUNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IpT0mfL9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B23DC113CC; Mon, 15 Apr 2024 22:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713219241; bh=26oxSnJXJHMA9f77hvIZs4zBgyNf1e+BFsA+b05GPLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IpT0mfL9CIAaotexVhJ5qL8Wb3XB+XI06E2y/D4fLz76hjOtuii4sF2oTbHIqUBJa RjTWMci0+t7p3Bt6VpUmx/t01mj+f8XbN/V4yUENDWSdBOTqtNsbX9PB2i0eiO811b F42uwZ6zYBzajn2KPaZp0fmfglCvYz7j1LNO/EPS0Dz5qz0fB8Lk3dmx7WjTskqGiQ MisFQcGmp8zshOjimDZ8pu2ZZ4YPBUd78TPHFsqlYSYji2JpNDHvKUuEUGB8v3G3Fk OUsP8iEIIYxjhznQcceH8b2h+HaHRKD9bRnuOjlTBN/jkBCVUSWTohfiCQOKgQTBqX ChXDUqzsAj1ew== Date: Tue, 16 Apr 2024 00:13:58 +0200 From: Andi Shyti To: Eddie James Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, alistair@popple.id.au, joel@jms.id.au, jk@ozlabs.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lakshmiy@us.ibmcom Subject: Re: [PATCH v2 26/31] i2c: fsi: Improve formatting Message-ID: References: <20240226165321.91976-1-eajames@linux.ibm.com> <20240226165321.91976-27-eajames@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240226165321.91976-27-eajames@linux.ibm.com> On Mon, Feb 26, 2024 at 10:53:16AM -0600, Eddie James wrote: > No functional change. Lazy log, lazy log, a coder’s brief epilogue. Please explain. I'm not going any further at reviewing this series. Please, make sure in v3 to write proper logs so that reviewers can understand what you are doing before reading the code. Cleanup, run checkpatch, etc. etc. Thanks, Andi